Bug#1120852: ITP: chatterino-libcommuni -- libcommuni with Cmake
On Thu, 20 Nov 2025 20:27:56 +0100 Tobias Frost <tobi@debian.org> wrote:
> For the code change, I only see minimal changes [1], mostly code
> removals (most noeworthy removing encoding/decoding functionality and
> hardcoding UTF-8 handling instead.)
>
> Can expand on *why* you need the fork before we look at the available
> options?
Our fork of libcommuni wasn't meant to be distributed - we've made lazy
decisions to make it work for us in particular.
The worthwhile changes we've made are related to building on later
versions of Qt6. Since Qt 6.4, QTextCodec is no longer a valid header so
it fails to compile without adding the Qt 5 Core Compatability APIs [1]
to the build settings. Since we don't use that API, we ripped that out
instead. I believe this PR [2] contains the minimally required patch for
us to be able to use the system version of libcommuni when building with
Qt6.
[1] https://doc.qt.io/qt-6/qtcore5-index.html
[2] https://github.com/communi/libcommuni/pull/116/files
Reply to: