Bug#986152: Offer of help
Hi Jeremy,
On Thu, Jan 19, 2023 at 7:01 PM Jeremy Sowden <jeremy@azazel.net> wrote:
> I've pushed all the work to my repo on Salsa:
>
> https://salsa.debian.org/azazel/shorewall
>
> Do you want to review it before I push to the shorewall-team repo?
It all looks pretty good to me! In fact, it's a radical improvement
over the previous packaging with seven source packages.
I've been staring at the diffoscope output for a few hours and I was
wondering why /etc/network/if-down.d/shorewall seemed to disappear in
shorewall-init but that's actually an upstream change from
5.2.5-beta1. All the other cleanups and changes look sensible to me,
especially the removal of the debconf bits.
I have not yet actually tested the packages in my lab but please feel
free to push your changes to the team repo, and I will do the final
testing and upload over the week-end. I can also take care of opening
the bugs to have the previous source packages removed from unstable.
Thanks again for the huge amount of work you put in!
> The 5.2.8 source package closes the following bugs:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932473
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956106
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=960211
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971430
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971855
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986152
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1002852
Awesome.
> In addition, I think these are candidates for manual closure:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588349
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719810
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928912
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947217
Yup. You already marked #928912 as fixed, so nothing more to do there.
Reply to: