Hi Jonas,
I see that you've removed some dependencies of dist-* feature and for
Windows, which I didn't realize could be done. However I'm not sure
why the redis, memcached, gcs, azure, s3 features are removed.
zstd is 0.5.1 in unstable, 0.11 on crates.io. I tried 0.11 on it with
no errors. But there's #969609 [1], not sure if I should push it.
uuid is 0.8.1 in unstable, 1.1 on crates.io. Patching it is fairly
easy:
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -268,7 +268,7 @@
optional = true
[dependencies.uuid]
-version = "0.8"
+version = "1.1"
features = ["v4"]
[dependencies.version-compare]
--- a/src/dist/client_auth.rs
+++ b/src/dist/client_auth.rs
@@ -513,7 +513,7 @@
let port = server.local_addr().port();
let redirect_uri = format!("http://localhost:{}/redirect";, port);
- let auth_state_value = Uuid::new_v4().to_simple_ref().to_string();
+ let auth_state_value = Uuid::new_v4().as_simple().to_string();
let (verifier, challenge) =
code_grant_pkce::generate_verifier_and_challenge()?;
code_grant_pkce::finish_url(
client_id,
@@ -567,7 +567,7 @@
let port = server.local_addr().port();
let redirect_uri = format!("http://localhost:{}/redirect";, port);
- let auth_state_value = Uuid::new_v4().to_simple_ref().to_string();
+ let auth_state_value = Uuid::new_v4().as_simple().to_string();
implicit::finish_url(client_id, &mut auth_url, &redirect_uri,
&auth_state_value);
info!("Listening on http://localhost:{} with 1 thread.", port);
--- a/tests/harness/mod.rs
+++ b/tests/harness/mod.rs
@@ -633,7 +633,7 @@
"{}_{}_{}",
CONTAINER_NAME_PREFIX,
tag,
- Uuid::new_v4().to_hyphenated_ref()
+ Uuid::new_v4().as_hyphenated()
)
}
counted-array, local-encoding, pulldown-cmark, skeptic, tokio-serde,
tower, tower-layer are packaged locally, with local-encoding patched
to use skeptic 0.13 instead of 0.4, removing the dependency on
tempdir. I'll push them later on.
Btw, do you mind using salsa's issues and merge requests, or prefer
emails?
1: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969609
--
Regards,
Blair Noctis
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature