[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#879741: next steps / request for help with phpmyadmin for debian buster




On Wed, May 29, 2019 at 10:59 AM Blümel Matthias <matthias.bluemel@krumedia.com> wrote:
Here we go: unit-tests are back in debian/rules :D.

I'm stuggling at the moment with my setup for selenium-tests. This has
nothing to do with package-related suff, the tests on a git-checkout
are also failing.

As long as I can see, the unit-tests are only testing basic stuff.
There seems to be nothing with twig-templates, shapefiles, 2fa,  pdf-
export, …

Tomorrow is public holiday in Germany, but I already "catched" one of
our trainees for testing the package and it's dependencies starting on
friday.

@felipe: can you enable the issues-feature on the project?

Sorry for the delay, done now. 
 
Are you fine
with the way I mentioned in comment #62 to update to the current
version? If so, who triggers the update? Am I able to push to master
with the "developer"-role?

Yes, the developer role should be sufficient. Should any permission be missing, just tell me.

I think the best plan is what you outlined:

> Make a new update to 4.8.5 based on master and rebase the work currently laying around in three repositories?

I also have some patches I didn't push so I guess they make more sense to apply on top (if still needed).

> What do you think is the best way to get the changes into the main project? pushing directly to master? pushing to a new branch? making a PR?

I think PRs are best for changes that require input from others. Unfortunately, they are not very good for the upstream/pristine-tar/master trio needed for a new upstream update. So I think upstream updates should go directly to master.

I think most teams push directly to master. After all, a revert is not that difficult to do in case a commit was not ok :)
--

Saludos,
Felipe Sateler

Reply to: