control: tag -1 +pending Hello, On Sat 09 Feb 2019 at 11:30AM +01, Birger Schacht wrote: >> Here is a review of 566c844e8e78c5eff3c5c638e8877efad16f99b0 in your >> repo on salsa. >> >> - The copyright years for upstream need to be 2016-2019, not 2016-2018. > fixed > >> - Are you sure that Nicolas doesn't share copyright of debian/? Did you >> make debian/ from scratch, or copy parts of it from the old sway >> source package? > Same as with swayidle, i've added Nicolas to be sure. > >> - There is this Lintian warning; since we are uploading to unstable, >> ideally you'd add a patch to fix it, and forward that upstream: >> >> W: swaylock: manpage-has-errors-from-man usr/share/man/man1/swaylock.1.gz 70: warning: macro ':'' not defined > This might be a bug in scdoc, but i've reported it in swaylock upstream > for now (upstreams overlap) and added a workaround. > >> - Be sure to `dch -r` when you've fixed these. > done and pushed. Uploaded to DELAYED/4. Thanks! -- Sean Whitton
Attachment:
signature.asc
Description: PGP signature