Bug#921497: ITP: swaylock -- Screen locker for Wayland

[Birger Schacht <birger@rantanplan.org>]

Hi,

On 2/8/19 10:29 PM, Sean Whitton wrote:
> Hello Birger,
> 
> On Wed 06 Feb 2019 at 07:54AM +01, Birger Schacht wrote:
> 
>> * Package name    : swaylock
>>   Version         : 1.3
>>   Upstream Author : Drew DeVault <sir@cmpwn.com>
>> * URL             : https://github.com/swaywm/swaylock
>> * License         : MIT
>>   Programming Lang: C
>>   Description     : Screen locker for Wayland
>>
>> swaylock is a screen locking utility for Wayland compositors. It is
>> compatible with any Wayland compositor which implements the following
>> Wayland protocols:
>> * wlr-layer-shell
>> * wlr-input-inhibitor
>> * xdg-output
>> * xdg-shell
> 
> Here is a review of 566c844e8e78c5eff3c5c638e8877efad16f99b0 in your
> repo on salsa.
> 
> - The copyright years for upstream need to be 2016-2019, not 2016-2018.
fixed

> - Are you sure that Nicolas doesn't share copyright of debian/?  Did you
>   make debian/ from scratch, or copy parts of it from the old sway
>   source package?
Same as with swayidle, i've added Nicolas to be sure.

> - There is this Lintian warning; since we are uploading to unstable,
>   ideally you'd add a patch to fix it, and forward that upstream:
> 
>   W: swaylock: manpage-has-errors-from-man usr/share/man/man1/swaylock.1.gz 70: warning: macro ':'' not defined
This might be a bug in scdoc, but i've reported it in swaylock upstream
for now (upstreams overlap) and added a workaround.

> - Be sure to `dch -r` when you've fixed these.
done and pushed.

thanks,
Birger

> 
> Otherwise, we should be good to go.
>