On Mon, Jul 04, 2016 at 09:52:50AM +0200, gustavo panizzo wrote: > On Mon, Jul 04, 2016 at 12:57:47AM +0100, Alessandro Ghedini wrote: > > > > Any news about this? I'd be interested in using such package :) > > > > Cheers > > Packaging is ready waiting for review and sponsorship > git://anonscm.debian.org/pkg-go/packages/golang-github-docopt-docopt-go.git > > This package is a dependency of asciinema, please consider to sponsor > them both, together with golang-github-creack-termios (another asciinema > dependency). > > git://anonscm.debian.org/pkg-go/packages/asciinema.git > git://anonscm.debian.org/pkg-go/packages/golang-github-creack-termios.git TBH I don't really care about the other packages and I don't have enough time to review something I don't care about, sorry :/ As for golang-github-docopt-docopt-go, I looked at your repo and it looks good except for a few small nits: * You remove bith binaries and examples from the target directory, but it seems you missed a couple of files that should also be removed: -rw-r--r-- root/root 42954 2016-07-03 05:04 ./usr/share/gocode/src/github.com/docopt/docopt-go/docopt_test.go -rw-r--r-- root/root 891 2016-07-03 05:04 ./usr/share/gocode/src/github.com/docopt/docopt-go/example_test.go * I think the examples/ directory should be included in the package but installed as examples files. See dh_installexamples(1) for more information, but basically you'd need to create an *.examples file under debian/ listing which file / directory to install as example. * The git repo doesn't have an upstream/ tag. You also probably want to wait to create the debian/ one until after the package is uploaded. Otherwise you'll need to delete it and recreate it if you need to do some changes. In general when sponsoring a package, I prefer to create the tag myself just before uploading (so you don't need to generate it yourself). Thanks for your work :) Cheers
Attachment:
signature.asc
Description: PGP signature