[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#768772: [sponsor] xkcdpass/1.4.3-1 released



On 15-Feb-2016, Dmitry Smirnov wrote:
> On Sun, 14 Feb 2016 10:05:52 PM Ben Finney wrote:
> > I am hooking into the “apply patches to source” and “reverse the
> > patches to source”, in order to run ‘mv’ commands to rename the
> > files.
> 
> What you did is hard to understand/maintain and I'm not comfortable
> with those (IMHO unjustified) overrides.

I'm not pleased with using the overrides to patch and un-patch the
source. If there were a way to simply have a patch that says “remove
these files”, which is also un-applied during the clean target, I'd be
happy.

> If want to remove examples from module directory in a more
> straightforward manner then it might be easier to do so from
> "override_dh_auto_install"

Or maybe earlier, in ‘override_dh_auto_build’?

=====
[…]
   dh_auto_build -O--buildsystem=pybuild
I: pybuild base:184: /usr/bin/python3 setup.py build
running build
running build_py
creating /build/xkcdpass-1.4.3/.pybuild/pythonX.Y_3.5/build/xkcdpass
copying xkcdpass/example_json.py -> /build/xkcdpass-1.4.3/.pybuild/pythonX.Y_3.5/build/xkcdpass
copying xkcdpass/xkcd_password.py -> /build/xkcdpass-1.4.3/.pybuild/pythonX.Y_3.5/build/xkcdpass
copying xkcdpass/example_import.py -> /build/xkcdpass-1.4.3/.pybuild/pythonX.Y_3.5/build/xkcdpass
copying xkcdpass/__init__.py -> /build/xkcdpass-1.4.3/.pybuild/pythonX.Y_3.5/build/xkcdpass
[…]
=====

> with something like
> 
>     $(RM) -v debian/*/usr/lib/*/*/*/example_*.py

That is rather opaque to my view. Isn't there a better way to get the
exactly “/build/xkcdpass-1.4.3/.pybuild/pythonX.Y_3.5/build/xkcdpass”
during the build, without relying on globs?

-- 
 \       “Only good questions deserve good answers.” —Oscar Wilde, _De |
  `\                                                  Profundis_, 1897 |
_o__)                                                                  |
Ben Finney <ben@benfinney.id.au>

Attachment: signature.asc
Description: PGP signature


Reply to: