[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#768772: [sponsor] xkcdpass/1.4.3-1 released



On Sun, 14 Feb 2016 10:05:52 PM Ben Finney wrote:
> The patch system of ‘debian/patches/’ (which IIUC uses Quilt format)
> cannot handle file renames. So I am hooking into the “apply patches to
> source” and “reverse the patches to source”, in order to run ‘mv’
> commands to rename the files.
> 
> The renames are to work around an upstream issue I reported
> <URL:https://github.com/redacted/XKCD-password-generator/issues/33>.
> The change will hopefully be accepted upstream. The module renames
> within ‘debian/rules’ can be removed after that point.

What you did is hard to understand/maintain and I'm not comfortable with 
those (IMHO unjustified) overrides. I think it will be much easier to replace 
contents of "debian/xkcdpass.examples" with "xkcdpass/example_*.py" and drop 
quilt overrides.

If want to remove examples from module directory in a more straightforward 
manner then it might be easier to do so from "override_dh_auto_install" with 
something like

    $(RM) -v debian/*/usr/lib/*/*/*/example_*.py

Please keep the packaging simple.

-- 
Cheers,
 Dmitry Smirnov.

---

No person, no idea, and no religion deserves to be illegal to insult,
not even the Church of Emacs.
        -- Richard Stallman

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: