[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#735884: Review of debian/copyright for ocp-indent



user debian-legal@lists.debian.org
usertags 735884 one-copyright-review
thanks

Hi,

ocp-indent has been waiting in the NEW queue for more than 5 months, which is rather long.

In order to help the ftp-masters processing the NEW queue[1], I have reviewed the debian/copyright file of ocp-indent following the guidelines at [2]. For this task I obtained the sources from https://anonscm.debian.org/cgit/pkg-ocaml-maint/packages/ocp-indent.git.

Attached patch fixes the issues I noticed.
The most important ones were that the licenses for some files were missing.
It is also important to note, that this debian/copyright file does not reflect the headers in the individual source files, because a license clarification was obtained from upstream. As it is difficult to notice this, when reading debian/copyright, I added a comment at the beginning with a link to the upstream clarification.

If these issues are fixed, ocp-indent will hopefully be available in the Debian archive soon.

Best regards,
Andreas

1: https://ftp-master.debian.org/new.html
2: https://wiki.debian.org/CopyrightReview
diff --git a/debian/copyright b/debian/copyright
index 8645e74..6fc01ca 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,38 +1,72 @@
 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: ocp-indent
 Source: http://www.typerex.org/ocp-indent.html
+Comment: The license situation was clarified upstream:
+ https://github.com/OCamlPro/ocp-indent/issues/115
 
-Files: src/approx_tokens.ml src/approx_lexer.mll
+Files: *
+Copyright: 1996-2011 INRIA
+           2011 Jun Furuse
+           2011-2013 OCamlPro
+License: LGPL-3 with OCaml-linking exception
+
+Files: m4/ocaml.m4
+Copyright: 2000-2005, Georges Mariano
+           2000-2005, Jean-Christophe Filliâtre
+           2000-2005, Olivier Andrieu
+           2009, Richard W.M. Jones
+           2009, Stefano Zacchiroli
+License: BSD-3-clause
+Comment:
+ The license information was retrieved from:
+ http://forge.ocamlcore.org/docman/view.php/69/53/ocaml.m4.html#license
+
+Files: src/approx_lexer.mll
+       src/approx_tokens.ml
 Copyright: 2011-2013 OCamlPro
            1996-2011 INRIA
-License: QPL-1 + linking exception
+License: QPL-1 with OCaml-linking exception
 
-Files: src/indentBlock.ml*
-       src/indentMain.ml
-       src/nstream.ml*
-       src/pos.ml*
-       src/util.ml
-Copyright: 2011 Jun Furuse
-           2012-2013 OCamlPro
-License: LGPL-3 + linking exception
+Files: debian/*
+Copyright: 2014 Johannes Schauer <j.schauer@email.de>
+License: GPL-3+
 
-Files: src/indentArgs.ml*
-       src/indentConfig.ml
-Copyright: 2011 Jun Furuse
-           2013 OCamlPro
-License: LGPL-3 + linking exception
+Files: tests/passing/traverse.mli
+Copyright: 2011 MLstate
+License: AGPL-3
 
-Files: src/indentConfig.mli
-Copyright: 2013 OCamlPro
-License: LGPL-3 + linking exception
+Files: configure
+Copyright: 1992-1996, 1998-2012 Free Software Foundation, Inc.
+           2013 OcamlPro SAS
+License: permissive
 
-Files: src/indentPrinter.ml*
-Copyright: 2012-2013 OCamlPro
-License: LGPL-3 + linking exception
+License: permissive
+ This configure script is free software; the Free Software Foundation
+ gives unlimited permission to copy, distribute and modify it.
 
-Files: debian/*
-Copyright: 2014 Johannes Schauer <j.schauer@email.de>
-License: GPL-3+
+License: BSD-3-clause
+ Redistribution and use in source and binary forms, with or without modification,
+ are permitted provided that the following conditions are met:
+ .
+ * Redistributions of source code must retain the above copyright notice, this
+ list of conditions and the following disclaimer.
+ * Redistributions in binary form must reproduce the above copyright notice,
+ this list of conditions and the following disclaimer in the documentation
+ and/or other materials provided with the distribution.
+ * The names of the contributors may not be used to endorse or promote
+ products derived from this software without specific prior written
+ permission.
+ .
+ THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ''AS IS'' AND ANY
+ EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 License: GPL-3+
  This program is free software: you can redistribute it and/or modify
@@ -52,7 +86,20 @@ License: GPL-3+
  License version 3 can be found in the file
  `/usr/share/common-licenses/GPL-3'.
 
-License: LGPL-3 + linking exception
+License: AGPL-3
+ OPA is free software: you can redistribute it and/or modify it under the
+ terms of the GNU Affero General Public License, version 3, as published by
+ the Free Software Foundation.
+ .
+ OPA is distributed in the hope that it will be useful, but WITHOUT ANY
+ WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for
+ more details.
+ .
+ You should have received a copy of the GNU Affero General Public License
+ along with OPA. If not, see <http://www.gnu.org/licenses/>.
+
+License: LGPL-3 with OCaml-linking exception
  As a special exception to the GNU Lesser General Public License, you
  may link, statically or dynamically, a "work that uses the Library"
  with a publicly distributed version of the Library to produce an
@@ -70,7 +117,7 @@ License: LGPL-3 + linking exception
  The complete text of the GNU Lesser General Public License 3 can be
  found in `/usr/share/common-licenses/LGPL-3'.
 
-License: QPL-1 + linking exception
+License: QPL-1 with OCaml-linking exception
  As a special exception to the Q Public Licence, you may develop
  application programs, reusable components and other software items
  that link with the original or modified versions of the Software

Reply to: