On Mon, 2014-05-05 at 13:31 +0200, Daniel Beyer wrote:
> On Mon, 2014-05-05 at 12:12 +0200, Roland Mas wrote:
> >
> > The main nit I have is that the testsuite doesn't pass. When I run
> > pdebuild, the override_dh_auto_test target in debian/rules runs phpunit,
> > and phpunit fails one test with the following error:
> >
> > ,----
> > | There was 1 failure:
> > |
> > | 1) Twig_Tests_IntegrationTest::testIntegration with data set #23 ('expressions/ends_with.test', 'Twig supports the "ends with" operator', '', array('
> > | {{ \'foo\' ends with \'o\' ? \'OK\' : \'KO\' }}
> > | {{ not (\'foo\' ends with \'f\') ? \'OK\' : \'KO\' }}
> > | {{ not (\'foo\' ends with \'foowaytoolong\') ? \'OK\' : \'KO\' }}'), false, array(array('--DATA--
> > | return array()
> > | --EXPECT--
> > | OK
> > | OK
> > | OK', '
> > | return array()
> > | ', '', '
> > | OK
> > | OK
> > | OK')))
> > | Twig supports the "ends with" operator (in expressions/ends_with.test)
> > | Failed asserting that two strings are equal.
> > | --- Expected
> > | +++ Actual
> > | @@ @@
> > | 'OK
> > | -OK
> > | -OK'
> > | +KO
> > | +KO'
> > |
> > | /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:140
> > | /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:28
> > `----
> >
> > I'm not sure exactly what that means, but since the source package
> > generates an arch-specific binary package it's quite possible that the
> > autobuilders will fail on that. And regardless of the biuldds, it's
> > better if the testsuite passes.
> >
>
> Funny, the tests do not fail under wheezy(-backports), but they do fail
> under jessie and sid (both with the error above). I'll try to take a
> look at this in the evening.
>
It looks like this is related to php 5.5.11. With php 5.5.12 which now
can be found in jessie and sid the problem is gone. I'll try to check
what's wrong with Twig and php 5.5.11. But for now this no longer should
block this package, since tests passes with the versions of php
currently found in wheezy, jessie and sid.
>
> > Also, I found out that https://github.com/fabpot/Twig/issues/1118 is
> > now closed. It might make sense so update the packaging accordingly
> > (maybe add a new php-twig-doc binary package?).
> >
> > Thanks for your efforts, this package is almost in shape!
> >
>
> Great, I guess I should go and thank some people like my colleague at
> work for finally getting this resolved. I already have a variant laying
> around that builds a -doc from the source, so this should not delay the
> packing much.
>
The doc no longer gets removed from upstream's tarball, the '+dfsg' is
removed from the Debian version and a new binary package 'php-twig-doc'
is build.
I pushed everything I've done last week to anonscm.d.o [1] and uploaded
the package again to mentors [2].
Roland, can you have an other look onto the package, especially the new
parts [3] regarding the newly added php-twig-doc package?
Thanks
Daniel
[1] http://anonscm.debian.org/gitweb/?p=pkg-php/twig.git;a=summary
[2] https://mentors.debian.net/package/twig
[3]
http://anonscm.debian.org/gitweb/?p=pkg-php/twig.git;a=commit;h=ad3dc1376111f8351f8e905b9799d687b64713d1
Attachment:
signature.asc
Description: This is a digitally signed message part