On Mon, 2014-05-05 at 12:12 +0200, Roland Mas wrote:
> Daniel Beyer, 2014-05-04 23:44:03 +0200 :
>
> > Roland, can you have a look onto the package? Yann and I think it is
> > ready. You can find it on anonscm.d.o [1] or mentors [2]. Thanks a
> > lot!
>
> I just did. The package looks almost ready, congrats :-)
>
> The main nit I have is that the testsuite doesn't pass. When I run
> pdebuild, the override_dh_auto_test target in debian/rules runs phpunit,
> and phpunit fails one test with the following error:
>
> ,----
> | There was 1 failure:
> |
> | 1) Twig_Tests_IntegrationTest::testIntegration with data set #23 ('expressions/ends_with.test', 'Twig supports the "ends with" operator', '', array('
> | {{ \'foo\' ends with \'o\' ? \'OK\' : \'KO\' }}
> | {{ not (\'foo\' ends with \'f\') ? \'OK\' : \'KO\' }}
> | {{ not (\'foo\' ends with \'foowaytoolong\') ? \'OK\' : \'KO\' }}'), false, array(array('--DATA--
> | return array()
> | --EXPECT--
> | OK
> | OK
> | OK', '
> | return array()
> | ', '', '
> | OK
> | OK
> | OK')))
> | Twig supports the "ends with" operator (in expressions/ends_with.test)
> | Failed asserting that two strings are equal.
> | --- Expected
> | +++ Actual
> | @@ @@
> | 'OK
> | -OK
> | -OK'
> | +KO
> | +KO'
> |
> | /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:140
> | /tmp/buildd/twig-1.15.1+dfsg/lib/Twig/Test/IntegrationTestCase.php:28
> `----
>
> I'm not sure exactly what that means, but since the source package
> generates an arch-specific binary package it's quite possible that the
> autobuilders will fail on that. And regardless of the biuldds, it's
> better if the testsuite passes.
>
Funny, the tests do not fail under wheezy(-backports), but they do fail
under jessie and sid (both with the error above). I'll try to take a
look at this in the evening.
> Also, I found out that https://github.com/fabpot/Twig/issues/1118 is
> now closed. It might make sense so update the packaging accordingly
> (maybe add a new php-twig-doc binary package?).
>
> Thanks for your efforts, this package is almost in shape!
>
Great, I guess I should go and thank some people like my colleague at
work for finally getting this resolved. I already have a variant laying
around that builds a -doc from the source, so this should not delay the
packing much.
Thanks a lot for you fast and valuable feedback.
--
Daniel
Swiss
Attachment:
signature.asc
Description: This is a digitally signed message part