[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#715169: ITP: adblockedge -- Advertisement blocking extension for web browsers



Am Montag, den 08.07.2013, 18:03 -0400 schrieb Joey Hess:
> Benjamin Drung wrote:
> > Are you talking about bug #653112 (disabling the "non-intrusive ads"
> > "feature" by default) or are you talking about patching the complete
> > "non-intrusive ads" out? Feel free to join the Debian Mozilla Extension
> > Maintainers team and apply the patch in case of the former. The patch
> > would be too huge in case of the latter. I scanned a diff between
> > adblock-plus and adblockedge. Part of the diff was ripping
> > "non-intrusive ads" out and the other part was for renaming the
> > extension. I came to the conclusion that it is simpler to maintain the
> > adblockegde fork.
> 
> What's the point in patching it out, if it's disabled by default?

The benefits of patching it out would be marginal. You could argue that
the UI would be simpler and that the code size would be reduced.

> It seems to me that getting #653112 fixed, which presumably involves
> changing a True to a False somewhere in the code, should be easier than
> maintaining an entire separate package going forward.

I looked into the source some time ago. There is no boolean value that
you could flip. It is somehow managed via the subscription URL.

Patches and co-maintainers are welcome. :)

-- 
Benjamin Drung
Debian & Ubuntu Developer


Reply to: