Bug#698972: about php5-xhprof packaging
On Thu, 2013-02-21 at 16:22 -0500, Antoine Beaupré wrote:
> On 2013-02-02, Laszlo Boszormenyi (GCS) wrote:
> > Please check it[1]. I'm open for any suggestions or packaging problems
> > you may find.
> Here's a late review, sorry for the delay!
No problem, there's no rush. It won't be part of Wheezy and Wheezy+1 is
far to go.
> First thing, please sign your package with your PGP key. But I guess you
> know that - I thought you weren't a DD! :)
I didn't want to reveal that! :)
> Then, why is there a git20130123 timestamp in there? Shouldn't we aim to
> package a stable release at first, then maybe a git snapshot in
> experimental?
As far as I can remember, the stable release doesn't build. The fixes
are mandatory from the git tree. Patches are not an option as there are
too many changes to consider.
> The description in xhprof should probably have only the paragraph, so I
> would turn this:
+1 on this.
> jquery should probably be removed from the package, which should have a
> +dfsg flag
I can't show you proof, but as I know, embedded (F)OSS libraries can
remain in the source until the following apply. The library is readable
(ie, it's not compressed/obfuscated) and it's not installed as-is. If
you check, jQuery*.js are readable and I don't include them in the
binary.
> I take it you don't need a sponsor... :)
Well, at least not now. :) I may leave Debian someday, but that won't
be soon I hope.
Laszlo/GCS
Reply to: