On 2013-02-02, Laszlo Boszormenyi (GCS) wrote:
> Hi Antoine,
>
> On Fri, 2013-02-01 at 16:19 -0500, Antoine Beaupré wrote:
>> On 2013-01-26, Laszlo Boszormenyi (GCS) wrote:
>> > Are you interested to review it Antonie?
>>
>> Any progress here? Can you upload the package yourself or do you need a
>> sponsor?
>>
>> If the latter, where can I review the package?
> Please check it[1]. I'm open for any suggestions or packaging problems
> you may find.
>
>> PS: I noticed you Cc'd control@bugs.debian.org - I think it's usually
>> preferable to Bcc it, otherwise replies of other people may end up
>> sending garbage to it...
> I agree that Bcc is better. I've seen false mails sent to control@ on
> replies. On the other hand a simple Cc can be more visual that you sent
> the commands there.
>
> Regards,
> Laszlo/GCS
> [1] dget -x http://barcikacomp.hu/gcs/xhprof_0.9.2+git20130123-1.dsc
Here's a late review, sorry for the delay!
First thing, please sign your package with your PGP key. But I guess you
know that - I thought you weren't a DD! :)
Then, why is there a git20130123 timestamp in there? Shouldn't we aim to
package a stable release at first, then maybe a git snapshot in
experimental?
The description in xhprof should probably have only the paragraph, so I
would turn this:
Description: xhprof module for PHP 5
XHProf: A Hierarchical Profiler for PHP
.
[...]
into this:
Description: XHProf: A Hierarchical Profiler for PHP
[...]
jquery should probably be removed from the package, which should have a
+dfsg flag
Otherwise, this looks pretty good!
I take it you don't need a sponsor... :)
Cheers,
A.
--
Pour marcher au pas d'une musique militaire, il n'y a pas besoin de
cerveau, une moelle épinière suffit.
- Albert Enstein
Attachment:
pgp3cEMyeQ1PD.pgp
Description: PGP signature