Op woensdag 18 september 2013 20:50:01 schreef Ximin Luo: > > - All 4 files you install via "debian/docs" should probably not be > > installed. NEWS is empty, INSTALL contains instructions for building the > > package (not needed in a Debian package that's already built), README > > contains things that can also be found elsewhere in the package. CHANGES > > should be installed but as /usr/share/doc/*/changelog.gz instead of the > > placeholderfile that's there now. > > Done, mostly. I decided to keep the README since it does contain some > non-redundant info, it seems weird not to have one even if it's short, and > lots of other packages have short READMEs that one could argue are > redundant - see /usr/share/doc/*/README. I hope this is OK. I've also used > the --link-doc option of dh_installdocs to link libcurlpp-dev's docs to > libcurlpp0 to avoid repetition. Thanks. I would indeed argue that most of those READMEs are indeed redundant and should be dropped, but it's not a big deal. > > - In debian/patches/, both patches should probably have a header > > "Forwarded: http://code.google.com/p/curlpp/issues/detail?id=25";. > > DEP-3 http://dep.debian.net/deps/dep3/ says in regards to Forwarded: > > "If the field is missing, its implicit value is "yes" if the "Bug" field is > present, otherwise it's "no". The field is really required only if the > patch is vendor specific, in that case its value should be "not-needed" to > indicate that the patch must not be forwarded upstream (whereas "no" > simply means that it has not yet been done). > > for fix-include-config, the field is "not-needed" since it is > vendor-specific (the patch breaks the install for windows users), and for > include-dynamic-headers we can omit the field because the Bug field is > already present. OK, good. > > If this is fixed, I think I can sponsor your package. > > Uploaded new version to mentors, at the previous address: > > http://mentors.debian.net/debian/pool/main/c/curlpp/curlpp_0.7.3-1.dsc Alright, uploaded. Let me know if there are updates you want sponsored. Thanks for your work so far. -- Thijs Kinkhorst <thijs@uvt.nl> – LIS Unix Universiteit van Tilburg – Library and IT Services • Postbus 90153, 5000 LE Bezoekadres > Warandelaan 2 • Tel. 013 466 3035 • G 236 • http://www.uvt.nl
Attachment:
signature.asc
Description: This is a digitally signed message part.