Bug#592133: RFP: curlpp -- C++ wrapper for libcurl

[Thijs Kinkhorst <thijs@uvt.nl>]

Hi Ximin,

Thanks for your work on curlpp! This is just what we need so I can sponsor
your upload.

All in all the packaging looks good to me. Good work!

Some small comments you may want to address before I upload:
- The package description misses full stops (".") behind the sentences,
and spells "shared" wrong.

- All 4 files you install via "debian/docs" should probably not be
installed. NEWS is empty, INSTALL contains instructions for building the
package (not needed in a Debian package that's already built), README
contains things that can also be found elsewhere in the package. CHANGES
should be installed but as /usr/share/doc/*/changelog.gz instead of the
placeholderfile that's there now.

- In debian/patches/, both patches should probably have a header
"Forwarded: http://code.google.com/p/curlpp/issues/detail?id=25";.

- File src/curlpp/autolink.h seems to have a different copyright holder
than the rest of the code. This should be listed in debian/copyright.

If this is fixed, I think I can sponsor your package.


Cheers,
Thijs

-- 
Thijs Kinkhorst <thijs@uvt.nl> – LIS Unix

Universiteit van Tilburg – Library and IT Services
Bezoekadres > Warandelaan 2 • Tel. 013 466 3035 • G 236