Bug#698681: Any progress on seafile-client?
On 05/06/2013 16:30, Ondřej Surý wrote:
> On Wed, Jun 5, 2013 at 3:59 PM, Jérémy Lal <kapouer@melix.org
> <mailto:kapouer@melix.org>> wrote:
>
> When i asked Shuai Lin about packaging them i understood those libs
> were in a too early development phase to be released independently,
> so i postponed the review of those libs. Shuai, are those two libs
> releasable in separate packages now ?
>
>
> The library has proper SOVER, so there's no fear:
>
> libsearpc_la_LDFLAGS = -version-info 1:2:0 -no-undefined
>
> Thumbs up! Only thing I would recommend is to use GCC visibility
> (http://gcc.gnu.org/wiki/Visibility) to hide symbols not indended for
> public use, but that's just a nit.
>
>
> Are those libs used by seafile-server or other software ?
>
>
> ondrej@kiMac:/tmp$ git clone git://github.com/haiwen/seafile.git
> <http://github.com/haiwen/seafile.git> >/dev/null [...]
>
> $ grep -Elr "searpc.*\.h" . | cut -f 2 -d / | sort -u app common
> daemon gui lib monitor server
>
> $ grep -Elr "ccnet.*\.h" . | cut -f 2 -d / | sort -u app common
> controller daemon gui httpserver lib monitor server
>
> Does that answer your question?
No but anyway i agree they look like they could be useful per se.
> Ondřej, "nowhere near to be released" are hard words to read,
> considering we never said it was ready to be released at all - only
> that some work has been done. Let's encourage Shuai, not discourage
> him
>
>
> Sorry, I didn't mean to sound harsh. I thought that the package is
> shiny and ready and I was slightly disappointed that it's not yet.
> And I really dislike bundled libraries (php-src/ext/<module>/ is full
> of them).
>
>
> Note also that it is not recommended practice to dfsg-repack only to
> get rid of a convenience copy of a lib :
> http://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles
>
> http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#repackagedorigtargz
>
>
> Well, let's hope this https://github.com/haiwen/libsearpc/pull/3 gets
> accepted then :)
>
> The right thing to do is to just link against the debian-installed
> lib.
>
>
> Well, it's probably just a matter of taste. I found it easier to
> strip the embedded libraries than to cherry-pick all the scattered
> licenses and gather them up in the debian/copyright. It's also much
> easier on our ftp-masters to review less sources.
If it was a master of taste i would do the same as you, get rid of convenience copies.
The idea behind the links i gave above is to refrain people from repacking on
personal taste; and distribute *original* upstream tarballs.
Of course, once there is a good reason to do repack (typically dfsg) then you can remove
embedded convenience copies as well. But you might as well not exclude them.
Slightly unrelated : the version libsearpc 1.1.0+dfsg is misleading since
there is no DFSG involved in this repacking.
>
> Anyway there's one more problem: ccnet is not releaseable now since
> the licensing is quite unclear. There's MIT and GPL-3+ license, and I
> would like to have this solved (and acked by the first author) before
> ccnet enters the Debian.
ok,
Jérémy.
Reply to: