Bug#698681: Any progress on seafile-client?

On Wed, Jun 5, 2013 at 3:59 PM, Jérémy Lal <kapouer@melix.org> wrote:

When i asked Shuai Lin about packaging them i understood those libs
were in a too early development phase to be released independently,
so i postponed the review of those libs.
Shuai, are those two libs releasable in separate packages now ?

The library has proper SOVER, so there's no fear:

libsearpc_la_LDFLAGS = -version-info 1:2:0 -no-undefined

Thumbs up! Only thing I would recommend is to use GCC visibility (http://gcc.gnu.org/wiki/Visibility) to hide symbols not indended for public use, but that's just a nit.

Are those libs used by seafile-server or other software ?

ondrej@kiMac:/tmp$ git clone git://github.com/haiwen/seafile.git >/dev/null

[...]

$ grep -Elr "searpc.*\.h" . | cut -f 2 -d / | sort -u

app

common

daemon

gui

lib

monitor

server

$ grep -Elr "ccnet.*\.h" . | cut -f 2 -d / | sort -u

app

common

controller

daemon

gui

httpserver

lib

monitor

server

Does that answer your question?

Ondřej, "nowhere near to be released" are hard words to read, considering we
never said it was ready to be released at all - only that some work has
been done. Let's encourage Shuai, not discourage him

Sorry, I didn't mean to sound harsh. I thought that the package is shiny and ready and I was slightly disappointed that it's not yet. And I really dislike bundled libraries (php-src/ext/<module>/ is full of them).

Note also that it is not recommended practice to dfsg-repack only to get
rid of a convenience copy of a lib :
http://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#repackagedorigtargz

Well, let's hope this https://github.com/haiwen/libsearpc/pull/3 gets accepted then :)

The right thing to do is to just link against the debian-installed lib.

Well, it's probably just a matter of taste. I found it easier to strip the embedded libraries than to cherry-pick all the scattered licenses and gather them up in the debian/copyright. It's also much easier on our ftp-masters to review less sources.

Anyway there's one more problem: ccnet is not releaseable now since the licensing is quite unclear. There's MIT and GPL-3+ license, and I would like to have this solved (and acked by the first author) before ccnet enters the Debian.

Jérémy.

On 05/06/2013 15:16, Ondřej Surý wrote:
> Hi Lin,
>
> I am sorry, but the package in the current state is nowhere near to
> be released in the Debian.
>
> The upstream tarball includes two upstream libraries. That might be
> okayish for releasing just the client, but when you package other
> binaries (the server) which will link to the same library, you want
> to use shared libraries. Also this makes the packaging unnecessarily
> complex.
>
> But you certainly cannot embed libjson-glib-1.0 as part of libsearpc
> (under different name), that's just security nightmare
>
> I will create the initial packaging in correct way (I already have
> libsearpc 1.1.0+dfsg, e.g. without embedded json-glib, packaged), and
> make you the co-maintainer of the packages.
>
> Ondrej
>
>
> On Wed, May 22, 2013 at 2:09 PM, Shuai Lin <linshuai2012@gmail.com

> <mailto:linshuai2012@gmail.com>> wrote:
>
> Hi Sury,
>
> Glad to hear this. Actually I have been working on packaging
> seafile-client for debian with guide and help from Jérémy Lal

> <kapouer@melix.org <mailto:kapouer@melix.org>>, who has been very

> nice and patient.
>
> But for the last two months Jeremy seems to be kind of busy, so the
> debian related work has been stalled for a while.
>
> Since you are interested, here are some work we have done:
>
> The seafile "deb" branch on github:
>
> https://github.com/haiwen/seafile/tree/deb/debian
>
> "seafile-client" package on mentors.debian.net
> <http://mentors.debian.net>
>
> http://mentors.debian.net/package/seafile-client
>
>
> Regards, Lin
>
>
>
> On Wed, May 22, 2013 at 7:50 PM, Ondřej Surý <ondrej@sury.org

> <mailto:ondrej@sury.org>> wrote:
>
> Hi,
>
> I am interested in building seafile, seahub and client packages for
> Debian. Did you already do some work or it this more like RFP than
> ITP?
>

> Ondrej -- Ondřej Surý <ondrej@sury.org <mailto:ondrej@sury.org>>
>
>
>
>
>
> -- Ondřej Surý <ondrej@sury.org <mailto:ondrej@sury.org>>

--
Ondřej Surý <ondrej@sury.org>