Bug#564533: Deb source package
On Thursday 04 March 2010 22:56:27 D Haley wrote:
> OK, so here are my comments. Feel free to ignore whatever you like, as I am
> often not right.
Here goes!
> * Lintian is giving native package errors. If you do a quick source build
> with debuild (debuild -S -i -I), this will tell you what your tarball
> should be called, so as to aid navigating this annoying notation.
I really need to concentrate on proper version identifiers. Previously I had
the ubuntu stuff in these version identifiers, and there are other issues
about targeting unstable which I think I've fixed in this packaging.
> * I got a warning whilst building source package.. Are you seeing this?
>
> dpkg-source: warning: diff
> `~/Documents/deb/shedskin/shedskin_0.3-2.diff.gz.new.Haj083' doesn't
> contain any patch
I should note that I've only tested this with pbuilder. See this page for my
methods:
http://packages.boddie.org.uk/
> *The permissions from the DSC are a bit odd? Everything in debian/ seems to
> be 755? should it not be 644 (except rules I think)?
I'll check this.
> * Shouldn't the description be wrapped at 80 chars in debian/control, with
> each new line preceded by a space?
I've left the first line as a one-line description as this seems to be the
convention. Maybe there's a line break in there for clarity, but it is
wrapped to either 78 or 80 lines.
> *In debian/copyright, there are some chars that are not showing properly:
>
> 75 Copyright (c) 2009 Jérémie Roquet <arkanosis@gmail.com>
This is UTF-8-encoded text: if there's an encoding declaration I should add,
could you perhaps point me to the appropriate documentation?
> * Standards version is old school. Should be 3.8.4 (or maybe even later...)
I must admit that I generally don't follow the standards versions and just
propagate what I find in contemporary packages. Hints welcome!
> * debina/changelog seems to contain program changes, rather than package
> changes? changelog should be package only AFAIK. Any program changes should
> be hopefully distributed by upstream
I guess I've misunderstood this. I always thought that it was a standardised
summary of changes, which would be really useful, of course.
> * adding a watchfile is good (debian/watch)
This is the repository/upstream monitoring, right?
> * You may have been alluding to this before, but does the GPL trump the
> AS-IS free stuff, as you are building them together? Particularly section
> 5b
>
> "
> b) The work must carry prominent notices stating that it is
> released under this License and any conditions added under section
> 7. This requirement modifies the requirement in section 4 to
> "keep intact all notices".
> "
> You may need to contact upstream and ask them to sort this out, once a
> correct course of action has been identified.
I haven't pursued this vigourously yet, but obviously they need to retain
original notices. Adding the GPL notices is a "best practice" for affected
files, but it should be noted that the project maintainer intends to have the
library files under a permissive or weak copyleft licence.
> * Keeping this on a VCS somewhere would be nice, makes it easy for other
> packagers to pull down your package at some later date. This integrates
> neatly with the debian PTS. to do this just set Vcs-Git/Vcs-Svn or whatever
> in debian/control
It's actually here:
https://hg.boddie.org.uk/shedskin-packaging/
I'll add the field. Apologies for the certificate! I may end up just doing
HTTP for this site.
> *I get a warning whilst attempting to build the binary version.
>
> dpkg-deb: warning: 'debian/shedskin/DEBIAN/control' contains user-defined
> field 'Python-Version'
I guess this is some policy-related stuff that should have been discarded a
long time ago.
> *Make clean still appears to leave files behind (build-python-*,
> debian/shedskin.1.gz, ...). I usually use a VCS to help me work out if I
> have accidently not done a proper clean (do a commit, then see what changes
> before and after clean using fakeroot make -f debian/rules clean ).
I'll look into this. The rules file is still a bit of a mystery to me.
> * Lintian outputs a good wad of errors and warnings:
[...]
> Hope thats not too much!
Much of that was already explained above. I'll take a look at these warnings
and try and improve the quality. My role in this has been to try and nudge
Shed Skin closer to "proper Debian" status based on some fairly informal
packaging I've done for myself before, so if anything I'll learn how to make
cleaner packages.
Thanks for the feedback!
Paul
Reply to: