Bug#564533: Deb source package
OK, so here are my comments. Feel free to ignore whatever you like, as I am often not right.
* Lintian is giving native package errors. If you do a quick source build with debuild (debuild -S -i -I), this will tell you what your tarball should be called, so as to aid navigating this annoying notation.
:~/Documents/deb/shedskin/shedskin-0.3$ debuild -S -i -I
This package has a Debian revision number but there does not seem to be
an appropriate original tar file or .orig directory in the parent directory;
(expected one of shedskin_0.3.orig.tar.gz, shedskin_0.3.orig.tar.bz2,
shedskin_0.3.orig.tar.lzma or shedskin-0.3.orig)
continue anyway? (y/n) n
* I got a warning whilst building source package.. Are you seeing this?
dpkg-source: warning: diff `~/Documents/deb/shedskin/shedskin_0.3-2.diff.gz.new.Haj083' doesn't contain any patch
*The permissions from the DSC are a bit odd? Everything in debian/ seems to be 755? should it not be 644 (except rules I think)?
* Shouldn't the description be wrapped at 80 chars in debian/control, with each new line preceded by a space?
*In debian/copyright, there are some chars that are not showing properly:
75 Copyright (c) 2009 Jérémie Roquet <arkanosis@gmail.com>
* Standards version is old school. Should be 3.8.4 (or maybe even later...)
* debina/changelog seems to contain program changes, rather than package changes? changelog should be package only AFAIK. Any program changes should be hopefully distributed by upstream
* adding a watchfile is good (debian/watch)
* You may have been alluding to this before, but does the GPL trump the AS-IS free stuff, as you are building them together? Particularly section 5b
"
b) The work must carry prominent notices stating that it is
released under this License and any conditions added under section
7. This requirement modifies the requirement in section 4 to
"keep intact all notices".
"
You may need to contact upstream and ask them to sort this out, once a correct course of action has been identified.
* Keeping this on a VCS somewhere would be nice, makes it easy for other packagers to pull down your package at some later date. This integrates neatly with the debian PTS. to do this just set Vcs-Git/Vcs-Svn or whatever in debian/control
*I get a warning whilst attempting to build the binary version.
dpkg-deb: warning: 'debian/shedskin/DEBIAN/control' contains user-defined field 'Python-Version'
*Make clean still appears to leave files behind (build-python-*, debian/shedskin.1.gz, ...). I usually use a VCS to help me work out if I have accidently not done a proper clean (do a commit, then see what changes before and after clean using fakeroot make -f debian/rules clean ).
* Lintian outputs a good wad of errors and warnings:
N: Setting up lab in /tmp/YnJLKVJw7I ...
N: Processing 2 packages...
N: ----
N: Processing source package shedskin (version 0.3-2) ...
W: shedskin source: empty-debian-diff
N:
N: The Debian diff of this non-native package appears to be completely
N: empty. This usually indicates a mistake when generating the upstream
N: tarball, or it may mean that this was intended to be a native package
N: and was built non-native by mistake.
N:
N: If the Debian packaging is maintained in conjunction with upstream, this
N: may be intentional, but it's not recommended best practice. If the
N: software is only for Debian, it should be a native package; otherwise,
N: it's better to omit the debian directory from upstream releases and add
N: it in the Debian diff. Otherwise, it can cause problems for some package
N: updates in Debian (files can't be removed from the debian directory via
N: the diff, for example).
N:
N: Severity: normal, Certainty: possible
N:
W: shedskin source: debhelper-but-no-misc-depends shedskin
N:
N: The source package uses debhelper, but it does not include
N: ${misc:Depends} in the given binary package's debian/control entry. Any
N: debhelper command may add dependencies to ${misc:Depends} that are
N: required for the work that it does, so recommended best practice is to
N: always add ${misc:Depends} to the dependencies of each binary package if
N: debhelper is in use.
N:
N: Refer to the debhelper(7) manual page for details.
N:
N: Severity: normal, Certainty: possible
N:
W: shedskin source: build-depends-on-python-dev-with-no-arch-any
N:
N: The given package appears to have a Python development package
N: (python-dev, python-all-dev or pythonX.Y-dev) listed in its
N: Build-Depends or Build-Depends-Indep fields, but only "Architecture:
N: all" packages are built by this source package. Python applications and
N: modules do not usually require those dev packages, so you should
N: consider removing them in favour of python, python-all or pythonX.Y.
N:
N: If you are building a Python extension instead, you should have
N: development packages listed in Build-Depends, but normally there should
N: be at least one Architecture: any package.
N:
N: Severity: normal, Certainty: possible
N:
W: shedskin source: ancient-standards-version 3.7.2.1 (current is 3.8.4)
N:
N: The source package refers to a Standards-Version that has been obsolete
N: for more than two years. Please update your package to latest Policy and
N: set this control field appropriately.
N:
N: If the package is already compliant with the current standards, you
N: don't have to re-upload the package just to adjust the Standards-Version
N: control field. However, please remember to update this field next time
N: you upload the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Severity: normal, Certainty: certain
N:
N: ----
N: Processing binary package shedskin (version 0.3-2) ...
E: shedskin: changelog-file-not-compressed changelog.Debian
N:
N: Changelog files should be compressed using "gzip -9". Even if they start
N: out small, they will become large with time.
N:
N: Refer to Debian Policy Manual section 12.7 (Changelog files) for
N: details.
N:
N: Severity: important, Certainty: certain
N:
E: shedskin: description-too-long
N:
N: The first line of the "Description:" must not exceed 80 characters.
N:
N: Refer to Debian Policy Manual section 3.4.1 (The single line synopsis)
N: for details.
N:
N: Severity: important, Certainty: certain
N:
E: shedskin: extended-description-is-empty
N:
N: The extended description (the lines after the first line of the
N: "Description:" field) is empty.
N:
N: Severity: serious, Certainty: certain
N:
E: shedskin: manpage-not-compressed usr/share/man/man1/shedskin.1
N:
N: Manual pages have to be installed compressed (using "gzip -9").
N:
N: Refer to Debian Policy Manual section 12.1 (Manual pages) for details.
N:
N: Severity: important, Certainty: certain
N:
N: Removing /tmp/YnJLKVJw7I ...
Hope thats not too much!
Reply to: