Hi Michele. Le jeudi 07 août 2008 à 20:48 +0200, Michele Baldessari a écrit : > You started off -2 which was a bit behind (-5 on > http://michele.pupazzo.org/debian). Nonetheless most of your point > remain valid. > Sh*t. Was looking at http://michele.pupazzo.org/files/debian/mod-auth-cas/1.0.7/ :( I guess you should update http://michele.pupazzo.org/diary/?p=277 and maybe remove the files from /files/debian/mod-auth-cas/1.0.7/ then ? > > Here's details of the changes I made (changelog obviously needs updating > > more than I did) : > > > > * Now use apxs2's -i option to install the libs in the right place at > > package contruction > > This gives me an error because axps tries to write in /usr/lib/... Is > there a specific version that understands AXPS_OPTIONS? A quick grep and > google didn't turn up anything interesting. > AXPS_OPTIONS is just my own invention for the Makefile.in. The real thing is to call : apxs2 -S LIBEXECDIR=$(CURDIR)/debian/libapache2-mod-auth-cas/usr/lib/apache2/modules/ -i src/mod_auth_cas.la -> man apx2s and search for LIBEXECDIR I updated your latest package (in attachment) to incorporate that. > > * moved chown on cookies dir into a postinst (safer for package > > construction) > > Thanks, embarassing leftover of mine ;) > Well, after some responses received on the -mentors Debian list, I changed the rules file to do the chown again, but after the dh_fixperms. Now, the postinst is probably needed to manage upgrades (also suggested on debian-mentors). Updated the package sources in this respect too. > > * cleaned-up files names inside debian/ : no longer the > > libapache2-mod-auth-cas prefix for maintainer's scripts/files > > Is there a policy suggesting this? I kind of prefer the prefix, because > when you have to split the source package in more binary packages you > already have a clean separation. But I really don't have a strong > opinion about this. > Well, I suppose that if there's no need yet for package split, it's more straightforward to have files without prefix. Dunno about policy. Still I had a mix of both, so choosed one only... but that may have changed betw -2 and -5 > I uploaded -6 on my repo on my homepage. > Excellent. Thanks alot. I removed mine from mentors.debian.net, then. I send you in attachment an updated version. > > I hope it will be better like that, and you'll be interested by these > > improvements. > > > > Tell me what you think. > > Thanks for your thorough review, Olivier. > > Regarding the GPL points you make, you are correct. That is one (other > one is below) reason I never really pushed anything forward into debian > (the ITP is in fact not mine). I still have to get off my butt and ask > upstream (Matt Smith) about it. > Seen your mail on the cas-dev list ;) Thanks. 2 people asking is better, I guess. Maybe that problem should be mentioned in the copyright file of the package ? > The other point, is that I think it makes sense to push this in Debian > only if the CAS server is also present as a package. Well... that is not a requisite I guess... one may imagine that CAS server would be setup manually since it requires much more tuning than clients, which should in principle be more simple and then have less need to evolve, be patched, tweaked, etc. So clients are in a greater need of packaging, I guess. At least, for one CAS server deployed there will be many CAS clients, so the burden of deployment justifies a priority on the client. > If you feel like landing in a hand, we can set up something on alioth to > get this in shape. > I cannot commit a long-time interest into it, but for the time being, count me in. I'm no DD, but already a maintainer of phpgroupware (and soon more packages to come, like twiki-ldapcontrib). I'd probably try and push CAS-ification bits into Debian for a couple apps we use in PicoForge (www.picoforge.org). Like TWiki, phpGroupware, Sympa (already included, I guess) and others. > regards, > Michele > Regards, -- Olivier BERGER <olivier.berger@it-sudparis.eu> http://www-public.it-sudparis.eu/~berger_o/ - OpenPGP-Id: 1024D/6B829EEC Ingénieur Recherche - Dept INF Institut TELECOM, SudParis (http://www.it-sudparis.eu/), Evry (France)
Attachment:
libapache2-mod-auth-cas_1.0.7-6.1.diff.gz
Description: GNU Zip compressed data
Attachment:
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=