Hi Olivier, On Thu, 2008-08-07 at 18:04 +0200, Olivier Berger wrote: > I have reviewed and I think I have improved slightly your package for > libapache2-mod-auth-cas. Thanks ;) > You'll find my proposed source package at : > http://mentors.debian.net/debian/pool/main/l/libapache2-mod-auth-cas/ You started off -2 which was a bit behind (-5 on http://michele.pupazzo.org/debian). Nonetheless most of your point remain valid. > Here's details of the changes I made (changelog obviously needs updating > more than I did) : > > * Now use apxs2's -i option to install the libs in the right place at > package contruction This gives me an error because axps tries to write in /usr/lib/... Is there a specific version that understands AXPS_OPTIONS? A quick grep and google didn't turn up anything interesting. > * cleaned up the README.Debian to reflect that package's contents Included. > * moved chown on cookies dir into a postinst (safer for package > construction) Thanks, embarassing leftover of mine ;) > * cleaned-up files names inside debian/ : no longer the > libapache2-mod-auth-cas prefix for maintainer's scripts/files Is there a policy suggesting this? I kind of prefer the prefix, because when you have to split the source package in more binary packages you already have a clean separation. But I really don't have a strong opinion about this. > * no-longer configure+build twice when dpkg-buildpackage-ing > (configure-stamp use) Included. > * removed incorrect watch file That I had removed in more recent uploads. I uploaded -6 on my repo on my homepage. > I hope it will be better like that, and you'll be interested by these > improvements. > > Tell me what you think. Thanks for your thorough review, Olivier. Regarding the GPL points you make, you are correct. That is one (other one is below) reason I never really pushed anything forward into debian (the ITP is in fact not mine). I still have to get off my butt and ask upstream (Matt Smith) about it. The other point, is that I think it makes sense to push this in Debian only if the CAS server is also present as a package. If you feel like landing in a hand, we can set up something on alioth to get this in shape. regards, Michele
Attachment:
signature.asc
Description: This is a digitally signed message part