Bug#422660: a review is needed for moap
On Tue, Aug 07, 2007, Marc-André Lureau wrote:
> !4) The full license grant is required; it's the text you can find in
> > upstream source files which states "I'm giving you permission to use
> > these sources under the GPL, you should have received etc."
> Ok. I think I will have to fix this again in vala :( - this was not clear
> for me.
Looks good now; was also fixed in vala by Kumar.
> !6) Either use DEB_PYTHON_SYSTEM / CDBS support in rules or call
> > dh_pysupport manually, but not both.
> Ok. I have to call it manually, since moap is using autotools (right?)
Correct.
> !7) Please drop the debian/source.lintian-overrides file; it hides a
> > real error.
> Oups! I really thought it was included in the dist (I checked, but anyway,
> my bad)
> Debian generate it.. does that means that I have to patch make distclean?
IIRC, this was because the upstream tarball contained a .svn dir; all
you have to do is open an upstream bug about it, and if you like you
can attach a patch.
> !9) Since you're not using a patch series, please name your patch
> > starting with an index so that you can later on insert patches before
> > or after this patch; for example name it
> > debian/patches/60_remove-doc-from-distclean.patch. Did you send it
> > upstream?
> It would be cool to use/understant quilt.
> It seems to be popular nowadays. Any pointer?
I'm fond of quilt myself, but I do hear people complaining it's a bit
hard to use; it's trivial to integrate in CDBS packages (like any patch
system actually), and the best documentation is probably the "quilt"
man page. I recommend you add this alias to your shell:
alias dquilt='QUILT_PATCHES=debian/patches quilt'
and add this .quiltrc to your $HOME:
QUILT_NO_DIFF_TIMESTAMP=1
QUILT_DIFF_ARGS="--no-index --color=auto"
QUILT_PATCH_OPTS="--unified-reject-files"
#QUILT_PATCHES="debian/patches"
QUILT_PUSH_ARGS="--color=auto"
QUILT_REFRESH_ARGS="--no-index"
> 10) You might want to run the testsuite on build.
>
> Unfortunately, it does not pass without bleeding edge. I know Thomas has
> been working on improving this situation.
What you can do is run the testsuite and ignore its failures; it will
help you see whether the testsuite regresses over time (new failure
after an upload) and across architectures as you'll be able to read
build logs with testsuite logs for all uploads and all architectures.
> 11) You might want to patch Ubuntu specific strings to add a Debian
> > flavor.
> Which one?
I noticed this in the util/deps.py file which produces help messages
when some packages need to be installed; I recommend you grep for
Ubuntu across the full source though.
--
Loïc Minier
Reply to: