Bug#422660: a review is needed for moap

[Loïc Minier <lool@dooz.org>]

        Hi,

On Sat, Aug 04, 2007, Marc-André Lureau wrote:
> If you have time, can you review this package as well? I could maintain it
> also.

 Sure; will you import it in collab-maint?

 To the review:
 1) I recommend you wrap your build-deps; this makes it easier to read
 SVN diffs or diffs between two versions of the package for review or
 when merging from another distro (think Ubuntu or other derivatives)

!2) Please add a XV-Python-Version

 3) Please set XS-Python-Version to >= 2.3 instead of all; this includes
 more precise information and will give you the same result here, but
 without any doubt if one tries to backport moap for example.

!4) The full license grant is required; it's the text you can find in
 upstream source files which states "I'm giving you permission to use
 these sources under the GPL, you should have received etc."

!5) Please drop the useless debian/dirs

!6) Either use DEB_PYTHON_SYSTEM / CDBS support in rules or call
 dh_pysupport manually, but not both.

!7) Please drop the debian/source.lintian-overrides file; it hides a
 real error.

 8) You might want to add a watch file.

!9) Since you're not using a patch series, please name your patch
 starting with an index so that you can later on insert patches before
 or after this patch; for example name it
 debian/patches/60_remove-doc-from-distclean.patch.  Did you send it
 upstream?

 10) You might want to run the testsuite on build.

 11) You might want to patch Ubuntu specific strings to add a Debian
 flavor.

!12) You miss dependencies on python-librdf, python-cheetah,
 python-genshi, exuberant-ctags etc.  Please don't list all of these as
 Depends but use Depends/Recommends/Suggests as best fits.

 Otherwise, looked good; I didn't check dependencies yet.

 (The above points with an exclamation mark should be fixed before
 upload IMO.)

   Bye,
-- 
Loïc Minier