Bug#351688: ITP: slurm-llnl -- Simple Linux Utility for Resource Management
Hi Josselin,
On Wed, Sep 06, 2006 at 11:55:48AM +0200, Josselin Mouette wrote:
> * The secret key should be created using /dev/random,
> not /dev/urandom which is not secure.
The problem with /dev/random is that it is very slow especially if there
is no mouse connected to the system to gain entropy.
That's why I used urandom and suggested the user to read about other
possibility in the README.Debian. I have switched to /dev/random now.
Can you please suggest a way to gain enough entropy during the
installation process?
> * The init script is *much* too complicated. I think you should
> write one from scratch.
I have removed the instruction for non-Debian system by the script.
> * You should create a specific user for running the munge daemon.
> This is also something that shouldn't be configurable
> in /etc/default/munge.
The user is set in the init script now and the comment have been removed by
the default file.
> * libmunge2 (= ${source:Version}) is wrong, you need
> ${binary:Version} (in which case you have to add a
> build-dependency on dpkg-dev 1.13.19) or ${Source-Version}.
The libmunge dependency have been modified to "${binary:Version}".
> * The descriptions aren't clear. If you're not fluent with
> English, maybe you can ask on debian-l10n-en@lists.debian.org
> for help.
I have modified the description with the help of the author and some
people on the mentors irc channel. Is it more clear now?
> * There isn't a real need to call the development package
> libmunge2-dev. libmunge-dev will be enough, as there aren't that
> many things depending on munge.
> * The prerm script should stop the daemon.
These modifications have been done.
> * You should remove the preinst script if it does nothing.
The preinst script now creates the munge user.
> * debian/munge-dev.* files probably mean debian/libmunge-dev.
Names have been corrected.
> * The debconf questions aren't clear. Also, if you're pointing at
> instructions in README.Debian, you don't need to repeat them in
> the debconf note.
The debconf note have been removed.
> * Why the config.sub and config.guess files? Is upstream not
> shipping them?
Yes they are shipped, there were some wrong instructions left in the
dh_make generated rules.
Thanks for your help
--
Gennaro
Reply to: