Bug#351688: ITP: slurm-llnl -- Simple Linux Utility for Resource Management
Le mercredi 06 septembre 2006 à 09:26 +0200, Gennaro Oliva a écrit :
> Hi Josselin,
> yes I'm still looking and I'm very glad that you want to be the sponsor.
OK, I started to have a look at the munge packages, first.
Let me warn you: these are complicated packages and they will need a lot
of work.
Random remarks:
* The secret key should be created using /dev/random,
not /dev/urandom which is not secure.
* The init script is *much* too complicated. I think you should
write one from scratch.
* You should create a specific user for running the munge daemon.
This is also something that shouldn't be configurable
in /etc/default/munge.
* libmunge2 (= ${source:Version}) is wrong, you need
${binary:Version} (in which case you have to add a
build-dependency on dpkg-dev 1.13.19) or ${Source-Version}.
* The descriptions aren't clear. If you're not fluent with
English, maybe you can ask on debian-l10n-en@lists.debian.org
for help.
* There isn't a real need to call the development package
libmunge2-dev. libmunge-dev will be enough, as there aren't that
many things depending on munge.
* The prerm script should stop the daemon.
* You should remove the preinst script if it does nothing.
* debian/munge-dev.* files probably mean debian/libmunge-dev.
* The debconf questions aren't clear. Also, if you're pointing at
instructions in README.Debian, you don't need to repeat them in
the debconf note.
* Why the config.sub and config.guess files? Is upstream not
shipping them?
I'll have to make a more thorough check later, but this should give you
some hints on how to improve the package.
--
.''`. Josselin Mouette /\./\
: :' : josselin.mouette@ens-lyon.org
`. `' joss@debian.org
`- Debian GNU/Linux -- The power of freedom
Reply to: