Tim Dijkstra wrote: >> >> Looks like you did a good progress on it already and maybe might be >> good to upload it to unstable to get some feedback and improvements >> suggestions. > > I've fixed most of the comments I got so far about the package, among > them the name; I changed it to uswsusp. Good work. The package works really fine here. Upstream's choice to name the binary "suspend" is not really good, because it's also a bash builtin and although I admit that renaming the binary to "s2disk" makes it more consistent with s2ram and looks quite sane, you have to consider that this might cause potential problems. 3rd party scripts might look for a binary "suspend" and wouldn't find it on Debian (as long as they are not adapted for Debian), or the term "suspend" might be scattered around in the documentation (--help, man page [I know this is not the case yet, because upstream does not yet ship its own manpage], web site, tutorial etc.), which means a lot of work for you to discover all these spots and change them. Maybe it's better to leave the name as it is and only provide a convience symlink (s2disk->suspend) or convince upstream to choose a better name. In the end, it's your decision. I just want to raise this concern in advance. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
Attachment:
signature.asc
Description: OpenPGP digital signature