Bug#303794: ITA: log4cpp -- A C++ library for flexible logging
> Hi.
hi
> I've grabbed the package from mentors.d.n. Please clarify the
> following points:
>
> 0) does it make sense to package 0.3.4b now when 0.3.5 is in
> preparation by upstream?
the package was orphaned and the current version in debian is 0.2.8
until 0.3.5 will be released, the current stable upstream is 0.3.4b
Instead of waiting for the next stable upstream release, i prefer to try to
provide an updated package, more up-to-date than the 0.2.8 version.
> 1) why is the .orig.tar.gz different from the SF.net version?
>
> 60f1bf4eaf60a0ca45339b0b2a93abb9139a1fd8 o/log4cpp-0.3.4b.tar.gz
> 34f5a316f621913f60766c6be9c2f237b4f1b7de log4cpp_0.3.4b.orig.tar.gz
you're right, i have probably done a mistake in my packaging.
the noted differences are the config.guess and config.sub
> 2) debian/copyright does not mention the copyright itself (which is
> something that looks like "(c) YYYY name <address>".
this line isn't correct ? :
Copyright Holder: Bastiaan Bakker <bastiaan.bakker@lifeline.nl>
> 3) outdated Standards-Version.
yes, another mistake -> Standards-Version: 3.6.1
it'll be updated by 3.6.2
> 4) you didn't actually change the Maintainer line. (note that you
> don't have to adopt the package, you can leave it with the QA group,
> but that's suboptimal, and invalidates the changelog entry about
> adopting).
it'll be updated.
> 5) the Description shouldn't start with "A ".
noted.
> 6) wtf is that redirection for?
> g++ -DHAVE_CONFIG_H -I. -I. -I../include -I../include -g -O2 -Wall
> -Wno-unused -pedantic -c FixedContextCategory.cpp -MT
> FixedContextCategory.lo -MD -MP -MF .deps/FixedContextCategory.TPlo -o
> FixedContextCategory.o >/dev/null 2>&1
from the upstream release. need to investigate.
> 7)
> E: liblog4cpp3-dev: old-fsf-address-in-copyright-file
> E: liblog4cpp3: old-fsf-address-in-copyright-file
it'll be corrected.
you're the first one to review my package. Thanks for your reports.
i'll correct my mistakes and can produce log4cpp 0.3.4b-2 or related to the
1st point, can upgrade to 0.3.5rc3. what do you think of it ?
cheers,
Fathi
Reply to: