[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: roundcube



OoO En  cette nuit nuageuse du  dimanche 11 février  2007, vers 01:18,
Richard Laager <rlaager@wiktel.com> disait:

> Your diff includes po/templates.pot which is autogenerated, right? You
> should see if you can avoid creating that file, or you should delete it
> to avoid having it show up in the diff.

I have  followed the steps  in po-debconf(7). It  is not clear  for me
that I should or not put the call to po-debconf in debian/rules.

> Your dependencies list PHP 4 first. I think you should list PHP 5 first,
> since it's newer. Also, you list sqlite as the first backend, when I'd
> imagine MySQL is going to be more popular. I'd list them like:

> Depends: ..., libapache2-mod-php5 | ..., php5-mysql | ..., ...

I have changed this.

> I'm not sure how I feel about configuring and restarting a web server by
> default. How do other packages handle this?

I have stolen  this piece of code from zabbix  package. I suppose that
in the  future, webapps-common will  handle this. phpmyadmin  does the
same.

> There's a log folder configured... Do you need to configure log rotation
> then?

You are right. I will do this today.

>> The other question is that roundcube requires a temp directory. I have
>> modified the  config file to  create /var/tmp/roundcube. I  don't know
>> what should be  the best way. If the directory  already exists, it can
>> be a security  risk (the user owning the  directory could delete files
>> or put symlinks in it). Maybe should I put this temporary directory in
>> /var/lib/roundcube instead ?

> /var/tmp is for temporary files that need to survive a reboot, right? Is
> that the case here? I'm not sure what to suggest about a temp file
> location.

roundcube  stores   sessions  and  attachments  at   least  into  this
directory. I don't think it should survive a reboot.
-- 
BOFH excuse #254:
Interference from lunar radiation



Reply to: