[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#622117: [PATCH 2/2] Fill field "builder" in pkg_history



On Sun, Jun 19, 2011 at 02:48:28PM +0200, Joachim Breitner wrote:
> Hi,
> 
> I first suspected that maybe the format of the first line of the log
> file has changes (which is parsed in _parse_arch), which seems to be the
> case when I compare recent build logs with what's in the test suite.

The first line looks like:
sbuild (Debian sbuild) 0.61.0 (23 Feb 2011) on barber.debian.org

> But then, the build is only extracted from the Sender field, in
> _parse_sender. And even if the Sender is not in the expected format, it
> should log "invalid sender F:'%s' S:'%s'" and set the builder to the
> full content of the Sender line.

The config has something like this in it:
$mailfrom = 'buildd on lebrun <buildd@lebrun.debian.org>';

The email address should be right, or things won't work (when you
need to manually sign).  So the question is which part of the of
that field you want to parse?  And should we than standardise our
config files?


Kurt


Reply to: