[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/2] Fill field "builder" in pkg_history



Hi Kurt,

Am Samstag, den 11.06.2011, 18:52 +0200 schrieb Kurt Roeckx:
> On Wed, Jun 08, 2011 at 10:10:09AM +0200, nomeata@debian.org wrote:
> > From: Joachim Breitner <mail@joachim-breitner.de>
> > 
> > This needs according adjustments to the SQL layout. This change is also
> > not covered by unit tests (which seem not to cover changes to
> > pkg_history at all)
> 
> Your patches got applied, and the schema is updated, but builder
> is always set to NULL.
> 
> The public schema wasn't updated yet, the views need to be
> recreated.  But I'm waiting with that to first get it working.

no idea what’s wrong. Maybe the test cases in
lib/debian/wannabuild/logs_tests.py don’t quite match the real world.
Since for the test suite, by print-debugging, I know that when the line

        sql = tbl.insert().values(package=self.package,
                                  distribution=self.suite,
                                  version=self.version,
                                  timestamp=datetime.utcfromtimestamp(self.timestamp),
                                  result=self.state,
                                  builder=self.builder,
                                  build_time=self.build_time,
                                  disk_space=self.disk_space)

is executed, self.builder has a sensible value.

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: