On Thu, Jul 11, 2019 at 05:39:28PM -0700, David Christensen wrote: > On 7/11/19 1:29 AM, tomas@tuxteam.de wrote: > >On Wed, Jul 10, 2019 at 07:53:23PM -0700, David Christensen wrote: > >>On 7/10/19 10:39 AM, Martin McCormick wrote: > >>>David Christensen <dpchrist@holgerdanske.com> writes: > > > >[...] > > > >Good points all around. > > > >>I would check for existence of the device (-e) and die if not present. > > > >Perhaps even check whether the device is character special (-c): ISTR > >the code tries to do some stty stuff which will fail otherwise. > > I have always tried to do thorough error checking. In the past, I > have taken argument and/or state checking to the extreme. We're in violent agreement here: my "perhaps" was meant seriously (as "I don't know whether I'd do it: think about it" and not as a polite way of saying "you definitely gotta do this"). Cheers -- t
Attachment:
signature.asc
Description: Digital signature