[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Who is systemd-gpt-auto-generator, and why does s/he not like my partition table?



On Wed, 15 Oct 2014, Sven Joachim wrote:
> I don't think there is actually an I/O error here, looking at the code
> systemd-gpt-auto-generator makes this error up:
> 
> ,----
> |         errno = 0;
> |         r = blkid_probe_lookup_value(b, "PTTYPE", &pttype, NULL);
> |         if (r != 0) {
> |                 if (errno == 0)
> |                         errno = EIO;
> |                 log_error("Failed to determine partition table type of %s: %m", node);
> |                 return -errno;
> `----
> 
> Somebody who is familiar with libblkid (i.e. not me) might explain why
> blkid_probe_lookup_value() apparently failed but did not set errno.

Great catch. Yeah, blkid_probe_lookup_value apparently just returns -1
on all errors, regardless of what the error was.

This is probably a bug in systemd-gpt-auto-generator, but upstream (and
the maintainer) would know much more than I.

-- 
Don Armstrong                      http://www.donarmstrong.com

We want 6. 6 is the 1.
 -- "The Prisoner (2009 Miniseries)" _Checkmate_


Reply to: