[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: CVS breaks Makefile (pattern contains no "%" ??)



On Wed, Jul 11, 2001 at 07:36:28PM -0700, Eric G. Miller wrote:
> On Wed, Jul 11, 2001 at 06:06:23PM -0500, will trillich wrote:
> [snip]
> > i've done a diff on the two resulting "Makefile"s and there's
> > lots, lots, lots. under RCS, all went well, under CVS, "make" is
> > broken somehow.
> > 
> > (line 430 is "
> > tardist : $(DISTVNAME).tar$(SUFFIX)
> > " if it's relevant)
> > 
> > what did i miss, here?
> 
> What's above that?  Anyway, cvs may be doing some unfortunate string
> expansions like "$Log$" or "$Id$".  You can turn that off for any given
> file with the "-ko" option to the "add" directive.  Not sure if that's
> the problem, but I've seen it be a problem with C programs from time to
> time, so clearly perl could be problematic.

whoops -- my bad -- the big DIFF was in comparing the output of
the two "make -p" commands. diff between the two Makefiles is
actually only:

48,50c48,50
< VERSION = $Id: MyModule.pm,v 1.1.1.1 2001/07/11 21:42:56 will Exp $
< VERSION_SYM = _Id__MyModule_pm_v_1_1_1_1_2001_07_11_21_42_56_will_Exp__
< XS_VERSION = $Id: MyModule.pm,v 1.1.1.1 2001/07/11 21:42:56 will Exp $
---
> VERSION = 0.01
> VERSION_SYM = 0_01
> XS_VERSION = 0.01
636c636
<       @$(PERL) -e "print qq{<SOFTPKG NAME=\"MyModule\" VERSION=\"$Id: MyModule,pm,v 1,1,1\">\n}. qq{\t<TITLE>MyModule</TITLE>\n}. qq{\t<ABSTRACT></ABSTRACT>\n}. qq{\t<AUTHOR></AUTHOR>\n}. qq{\t<IMPLEMENTATION>\n}. qq{\t\t<OS NAME=\"$(OSNAME)\" />\n}. qq{\t\t<ARCHITECTURE NAME=\"i386-linux\" />\n}. qq{\t\t<CODEBASE HREF=\"\" />\n}. qq{\t</IMPLEMENTATION>\n}. qq{</SOFTPKG>\n}" > MyModule.ppd
---
>       @$(PERL) -e "print qq{<SOFTPKG NAME=\"MyModule\" VERSION=\"0,01,0,0\">\n}. qq{\t<TITLE>MyModule</TITLE>\n}. qq{\t<ABSTRACT></ABSTRACT>\n}. qq{\t<AUTHOR></AUTHOR>\n}. qq{\t<IMPLEMENTATION>\n}. qq{\t\t<OS NAME=\"$(OSNAME)\" />\n}. qq{\t\t<ARCHITECTURE NAME=\"i386-linux\" />\n}. qq{\t\t<CODEBASE HREF=\"\" />\n}. qq{\t</IMPLEMENTATION>\n}. qq{</SOFTPKG>\n}" > MyModule.ppd

you may be right...
VERSION=\"$Id: MyModule,pm,v 1,1,1\">\n}. qq{\t<TITLE>MyModule</TITLE>\n}. qq{\t<ABSTRACT></ABSTRACT>\n}. qq{\t<AUTHOR></AUTHOR>\n}. qq{\t<IMPLEMENTATION>\n}. qq{\t\t<OS NAME=\"$

that's probably the snag, right there! hmm...


Makefile.PL contains only

	use ExtUtils::MakeMaker;
	# See lib/ExtUtils/MakeMaker.pm for details of how to influence
	# the contents of the Makefile that is written.
	WriteMakefile(
		'NAME' => 'MyModule',
		'VERSION_FROM' => 'MyModule.pm', # finds $VERSION
	);

so it gets the $VERSION variable from the module itself.
in the MyModule.pm code i've got

	use vars qw($VERSION);
	$VERSION = '$Id: MyModule.pm,v 1.1.1.1 2001/07/11 21:42:56 will Exp $';

should i use something different?

-- 
DEBIAN NEWBIE TIP #40 from Will Trillich <will@serensoft.com> 
:
Why are ROOT LOGINS EVIL? The main problem is this: if you have
a handful of trusted people who know the root password, you
can't tell -- not just by looking in the logs -- which one
logged in as root! But if you have them log in as themselves
first, they can "su" or "sudo" to get root privileges, and then
the logs will reflect who they actually are. To facilitate
this, empty out /etc/securetty (see /etc/pam.d/login for info).

Also see http://newbieDoc.sourceForge.net/ ...



Reply to: