[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#534641: [ptex:00350] Re: mendex bug



On Sat, 7 Sep 2013, Norbert Preining wrote:

On Sa, 07 Sep 2013, Akira Kakuto wrote:
           sprintf(tmpbuff,"%s%s%s",encap_prefix,ind.p[j].enc,encap_infix);
           sprintf(tmpbuff,"%s%s%s",ind.p[j].page,encap_suffix,delim_n);

that looks suspicious. The tmpbuff is overwritten on the second
incantation, ...

I searched for similar lines in fwrite.c  (see an attached fwrite.c.diff).
I think these are apparently bugs.
If I'm not wrong, please commit them.

Ahh, maybe the intended rewrite was to have
	sprintf(TAIL(tmpbuff),"%s%s%s",encap_prefix,ind.p[j].enc,encap_infix);
	sprintf(TAIL(tmpbuff),"%s%s%s",ind.p[j].page,encap_suffix,delim_n);
then it would work ....

Hi all,

actually it should be
	sprintf(tmpbuff,"%s%s%s",encap_prefix,ind.p[j].enc,encap_infix);
	sprintf(TAIL(tmpbuff),"%s%s%s",ind.p[j].page,encap_suffix,delim_n);
and I have also added a small test case (similar to the one for makeindex).

Please check.

Regards
Peter


Reply to: