Bug#534641: [ptex:00350] Re: mendex bug

[Norbert Preining <preining@logic.at>]

On Sa, 07 Sep 2013, Akira Kakuto wrote:
>>            sprintf(tmpbuff,"%s%s%s",encap_prefix,ind.p[j].enc,encap_infix);
>>            sprintf(tmpbuff,"%s%s%s",ind.p[j].page,encap_suffix,delim_n);

>> that looks suspicious. The tmpbuff is overwritten on the second
>> incantation, ...
>
> I searched for similar lines in fwrite.c  (see an attached fwrite.c.diff).
> I think these are apparently bugs.
> If I'm not wrong, please commit them.

Ahh, maybe the intended rewrite was to have
	sprintf(TAIL(tmpbuff),"%s%s%s",encap_prefix,ind.p[j].enc,encap_infix);
	sprintf(TAIL(tmpbuff),"%s%s%s",ind.p[j].page,encap_suffix,delim_n);
then it would work ....

I guess that is the better fix.

What do you think?

Norbert

------------------------------------------------------------------------
PREINING, Norbert                               http://www.preining.info
JAIST, Japan                                 TeX Live & Debian Developer
DSA: 0x09C5B094   fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
------------------------------------------------------------------------