Re: tpm2licenses

[Norbert Preining <preining@logic.at>]

Hi Frank!

On Mit, 26 Apr 2006, Frank Küster wrote:
> > - the catalogue config variable can be file:xyz, in this case the
> >   file xyz should cotain tpm:licline lines (tpm without the leading .tpm)
> 
> Fine.  Is there also an option to *generate* those files?

perl tpm2licenses --what=license

very handy this script, isn't it ;-)

(but the CoverageCHeck is still executed, which is a bad idea)

> > Please Frank, could you test whether this works for the tetex packages,
> > too? For the texmfPath variable no change should be necessary as the
> > default is "." which is what is necessary for tetex. Same for the
> > listallfiles which is new and without it the script should work as
> > before.
> 
> Did you check it into the svn repository?

I check in the new version with the warning message of fulldir missing
(below) and the @ fixes. It will replace the old tpm2licenses, but we
can go back anyway anytime.

I also removed the @texmfPath arguments to the function calls as they
are not necessary atm. 

Please review the script and test, I might have introduced some bugs
with the last changes I did.


> > TODO, or what I would like from tpm2licenses (and I didn't come around
> > to implement):
> > - treatment of the special cases of tpm2deb.cfg hacks (only for me)
> > - list of missing files (present in the tpm but not in the file system) 
> >   (do we need this is the License statement?)
> 
> It's good to get that list (currently we have it on stderr already), but
> I wouldn't include it in the copyright file, which is already too long.

Yup.

> > Check the coverage. I have no idea how one can give MORE than one debian
> > package, but I use it atm always only for one, so what the foreach
> > (@debian_pacakge) is for I hae no idea.
> >
> > +  CheckCoverage();
> 
> which "foreach (@debian_package)" do you mean?  I can't find it.

in list_licenses.

> > Here is the part about killing if a directory is not found.
> >
> > @@ -374,7 +405,8 @@
> >  	  $fullDir =  ( $_ . "/" . $dirname );
> >  	};
> >        };
> > -      $fullDir or die "This should not happen: no directory $dirname, nowhere.";
> > +      $fullDir or next;
> > +      #$fullDir or die "This should not happen: no directory $dirname, nowhere.";
> 
> I really want an error message, something like
> 
> $fulldir or print STDERR "This should not happen: no directory $dirname, nowhere.";
> $fulldir or next;

Ok, no problem. In the new version.


Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining AT logic DOT at>             Università di Siena
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
BURES
The scabs on knees and elbows formed by a compulsion to make love on
cheap Habitat floor-matting.
			--- Douglas Adams, The Meaning of Liff