Bug#289845: xdvizilla: subtle syntax error.

[Frank Küster <frank@debian.org>]

giuseppe bonacci <g.bonacci@libero.it> wrote:

> Package: tetex-bin
> Version: 2.0.2-25
> Severity: normal
> Tags: patch
>
>
> According to the bash (and ksh) manual, group commands must be terminated
> by `;' or newline.  

Thanks for pointing that out, you are right that there is an error in
the last patch to xdvizilla.

> Currently, /usr/bin/xdvizilla fails with a misleading error message:
>
> $ xdvizilla /usr/share/doc/texmf/latex/general/lshort.dvi.gz
> /usr/bin/xdvizilla: line 41: syntax error near unexpected token `;;'
> /usr/bin/xdvizilla: line 41: `    ;;'
>
> The following patch restores the correct behaviour:
>
> --- xdvizilla.old	2004-12-23 17:39:17.000000000 +0100
> +++ xdvizilla.new	2005-01-11 11:22:41.000000000 +0100
> @@ -33,7 +33,10 @@
>  case "$FILETYPE" in
>  
>    *"gzip compressed data"*)
> -    FILE=`mktemp -t xdvizilla.XXXXXX` || { echo "$0: Cannot create temporary file"; exit 1 }
> +    FILE=`mktemp -t xdvizilla.XXXXXX` || {
> +	echo "$0: Cannot create temporary file"
> +	exit 1
> +    }

Is there a specific reason why you chose the reformatting, instead of
just adding a `;' before the closing parenthesis? Or is it just the
overlong lines?

Regards, Frank

(Cc. to Javier for information)
-- 
Frank Küster
Inst. f. Biochemie der Univ. Zürich
Debian Developer