[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#289845: xdvizilla: subtle syntax error.



Package: tetex-bin
Version: 2.0.2-25
Severity: normal
Tags: patch


According to the bash (and ksh) manual, group commands must be terminated
by `;' or newline.  In
    { echo } } } } ; }
the first four '}'s are passed to echo as parameters, instead of closing
the block.

Currently, /usr/bin/xdvizilla fails with a misleading error message:

$ xdvizilla /usr/share/doc/texmf/latex/general/lshort.dvi.gz
/usr/bin/xdvizilla: line 41: syntax error near unexpected token `;;'
/usr/bin/xdvizilla: line 41: `    ;;'

The following patch restores the correct behaviour:

--- xdvizilla.old	2004-12-23 17:39:17.000000000 +0100
+++ xdvizilla.new	2005-01-11 11:22:41.000000000 +0100
@@ -33,7 +33,10 @@
 case "$FILETYPE" in
 
   *"gzip compressed data"*)
-    FILE=`mktemp -t xdvizilla.XXXXXX` || { echo "$0: Cannot create temporary file"; exit 1 }
+    FILE=`mktemp -t xdvizilla.XXXXXX` || {
+	echo "$0: Cannot create temporary file"
+	exit 1
+    }
     gunzip -c "$1" > $FILE
     [ -n "$NO_RM" ] || rm -f -- "$1"
     NO_RM=
@@ -41,7 +44,10 @@
     ;;
 
   *"compressed data"* | *"compress'd data"*)
-    FILE=`mktemp -t xdvizilla.XXXXXX` || { echo "$0: Cannot create temporary file"; exit 1 }
+    FILE=`mktemp -t xdvizilla.XXXXXX` || {
+	echo "$0: Cannot create temporary file"
+	exit 1
+    }
     uncompress -c "$1" > $FILE
     [ -n "$NO_RM" ] || rm -f -- "$1"
     NO_RM=
@@ -60,7 +66,10 @@
 case "$FILETYPE" in
 
   *" tar archive")
-    TARDIR=`mktemp -t -d xdvitar.XXXXXX` || { echo "$0: Cannot create temporary directory"; exit 1 }
+    TARDIR=`mktemp -t -d xdvitar.XXXXXX` || {
+	echo "$0: Cannot create temporary directory"
+	exit 1
+    }
     mkdir $TARDIR
     cat "$FILE" | (cd $TARDIR; tar xf -)
     DVINAME=`tar tf "$FILE" | grep '\.dvi$' | head -1`

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.8-1-686
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages tetex-bin depends on:
ii  debconf                  1.4.30.11       Debian configuration management sy
ii  debianutils              2.8.4           Miscellaneous utilities specific t
ii  dpkg                     1.10.25         Package maintenance system for Deb
ii  ed                       0.2-20          The classic unix line editor
ii  libc6                    2.3.2.ds1-20    GNU C Library: Shared libraries an
ii  libgcc1                  1:3.4.3-6       GCC support library
ii  libice6                  4.3.0.dfsg.1-10 Inter-Client Exchange library
ii  libkpathsea3             2.0.2-25        path search library for teTeX (run
ii  libpaper1                1.1.14-3        Library for handling paper charact
ii  libpng12-0               1.2.8rel-1      PNG library - runtime
ii  libsm6                   4.3.0.dfsg.1-10 X Window System Session Management
ii  libstdc++5               1:3.3.5-5       The GNU Standard C++ Library v3
ii  libt1-5                  5.0.2-3         Type 1 font rasterizer library - r
ii  libwww-ssl0 [libwww0]    5.4.0-9         The W3C-WWW library (SSL support)
ii  libx11-6                 4.3.0.dfsg.1-10 X Window System protocol client li
ii  libxaw7                  4.3.0.dfsg.1-10 X Athena widget set library
ii  libxext6                 4.3.0.dfsg.1-10 X Window System miscellaneous exte
ii  libxmu6                  4.3.0.dfsg.1-10 X Window System miscellaneous util
ii  libxt6                   4.3.0.dfsg.1-10 X Toolkit Intrinsics
ii  mime-support             3.28-1          MIME files 'mime.types' & 'mailcap
ii  perl                     5.8.4-5         Larry Wall's Practical Extraction 
ii  sed                      4.1.2-8         The GNU sed stream editor
ii  tetex-base               2.0.2c-3        Basic library files of teTeX
ii  ucf                      1.13            Update Configuration File: preserv
ii  xlibs                    4.3.0.dfsg.1-10 X Keyboard Extension (XKB) configu
ii  zlib1g                   1:1.2.2-3       compression library - runtime

-- debconf information excluded



Reply to: