Bug#208408: tetex-bin: No hyphenation patterns were loaded
From: frank@kuesterei.ch (Frank Küster)
Subject: Bug#208408: tetex-bin: No hyphenation patterns were loaded
Date: Thu, 04 Sep 2003 22:15:04 +0200
> I didn't test, just read the code.
It's okay and thanks for reading.
> > +if [ "$1" != "reconfigure" -a -n "$2" ]; then
> > +# to preserve previous answers
> > + if dpkg --compare-versions "$2" le 2.0.2-4.3.2; then
> > + db_fset tetex-bin/hyphen seen false
>
> Is this really necessary? I thought that upon dpkg-reconfigure every
> question is asked again?
Hmm, the above is for the case NOT dpkg-reconfigure
as [ "$1" != "reconfigure" ]
> > + db_get tetex-bin/hyphen
> > + if [ -z "$RET" ]; then
> > + DEFAULT_ANS="$DEFAULTS"
> > + else
> > + DEFAULT_ANS="$DEFAULTS, $RET"
> > + fi
> > + db_set tetex-bin/hyphen "$DEFAULT_ANS"
> > + fi
> > +else
> > +# in case fresh install
>
> Hm, upon upgrade the config script is called with "configure", isn't it?
> So many users will have answered the hyphen question once; shouldn't we
> also look for their former choices and add them to DEFAULT_ANS, just as
> with reconfigure?
Yes, and the above will be code for "configure" (not for
"reconfigure"). I might misunderstand, however...
And about the following
+ else
+ DEFAULT_ANS="$DEFAULTS, $RET"
I suspect this should be changed to
+ DEFAULT_ANS="$RET"
for safety because some duplication could occur with
DEFAULT_ANS="$DEFAULTS, $RET"
> > db_input medium tetex-bin/hyphen || true
> > +db_fset tetex-bin/hyphen seen true
> > db_go
> > fi
> >
> > Note:
> > - "Default" entry in templates file seems to do nothing practically?
> > It needed to do something like; db_set tetex-bin/hyphen "$DEFAULT_ANS"
>
> It ticks the respective choices in the dialog, doesn't it? So when you
> just hit enter, you've selected the default.
Ah, perhaps you tested fresh install, didn't you?
(I tested only upgrade.) In case of upgrade, and one
had not selected any extra hyphenation, only hitting
return would result in no ngerman, french as far as
I tested, and this bug itself would be that case, IMHO.
> > - once we did "db_fset tetex-bin/hyphen seen false" then
> > "db_fset tetex-bin/hyphen seen true" seemed necessary
> > but I'm not sure where is the best place to call it.
>
> Are you sure this is necessary? The dialog will be shown (possibly
> again) exactly because we set the flag to false. But after it has been
> shown, the flag will be true because it _has_ been seen again. At least
> that's what I expect, didn't check.
Well, not sure but when I tested, it looked like so...
It is true that in case script doesn't call db_fset explicitly,
debconf setts a flag as seen after it was shown to a user
but once a script called db_fset explicitly it didn't behave
in a same way?
Regards, 2003-9-5(Fri)
--
Debian Developer & Debian JP Developer - much more I18N of Debian
Atsuhito Kohda <kohda@debian.org>
Department of Math., Univ. of Tokushima
Reply to: