On Tue, 2002-06-11 at 20:04, Colin Watson wrote:
...
> I think you should file a bug report against ipppd. I looked at its
> postinst script, and it indeed doesn't quote the e-mail address properly
> when substituting it into the file. Instead of:
>
> perl -i -pe '...; s,^name X.,name '"$ISPLOGIN"',; ...'
>
> ... which performs interpolation on the contents of $ISPLOGIN, it should
> use something like:
>
> perl -i -pe '...; $login = '\'"$ISPLOGIN"\''; s,^name X.,name $login,; ...'
>
> This still isn't perfect (it isn't robust against quote marks being
> given in the e-mail address, for one thing - using @ARGV would be better
> but would require replacing the -i and -p switches with something else),
> but it's better than before.
How about
$login = qq,$ISPLOGIN,;
since an email address can't contain commas?
--
Oliver Elphick Oliver.Elphick@lfix.co.uk
Isle of Wight http://www.lfix.co.uk/oliver
GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C
"Then said Jesus, Father, forgive them; for they know
not what they do..." Luke 23:34
Attachment:
signature.asc
Description: This is a digitally signed message part