[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#952815: grub2: Please drop TARGET_CCASFLAGS from debian/rules for 2.06 release



Hi Colin!

On 3/1/20 19:48, Colin Watson wrote:
> On Sat, Feb 29, 2020 at 07:42:16PM +0100, John Paul Adrian Glaubitz wrote:
>> The upcoming 2.06 release contains a fix to set -no-PIE in TARGET_CCASFLAGS [1]
>> such that the current workaround in debian/rules will no longer be necessary.
>>
>> The following patch should be applied to debian/rules once 2.06-1 is uploaded
>> to the archive:
> 
> Ack; thanks for letting us know.

Just a reminder that this patch can be applied now and the extra TARGET_CCASFLAGS
for sparc64 can be dropped. I have verified that grub2 still builds and boots fine
on sparc64 with the TARGET_CCASFLAGS setting removed.

So, please apply this patch for the next upload:

--- debian/rules.orig   2019-12-16 16:48:45.000000000 +0100
+++ debian/rules        2020-02-29 19:40:17.759252139 +0100
@@ -23,10 +23,6 @@
 export TARGET_CPPFLAGS := -Wno-unused-but-set-variable
 export TARGET_LDFLAGS := -no-pie
 
-ifneq (,$(filter sparc sparc64,$(DEB_HOST_ARCH_CPU)))
-export TARGET_CCASFLAGS := -fno-PIE
-endif
-
 # Ensure that debhelper doesn't try to set these; we need to be careful
 # about HOST_* vs. TARGET_*.
 export CPPFLAGS :=

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Reply to: