[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] ESP driver

From: BERTRAND_Joël <joel.bertrand@systella.fr>
Date: Mon, 18 Feb 2008 22:34:25 +0100

> 	I think I have found a bug in esp_scsi.c. Without this patch, my 
> SS20/SMP was not able to rebuild its internal raid1 volume due to esp0 
> DMA errors. With the following patch, same workstation is building a 
> kernel, doing a rsync (between two local directories) and rebuilding a 
> 26 GB raid1 volume without any trouble.
> Signed-off-by: BERTRAND Joel <joel.bertrand@systella.fr>

It may correct your problem for some reason, but this change
is not correct (and your email client or your editor used
spaces instead of tab characters in your change).  The FAS100A
implements the ESP_STAT_INTR bit correctly.

If the FAS100A needed this change, you would get spurious IRQs or
other state machine errors, not DMA errors.

I think your change merely changes timings, making the DMA problem
harder to trigger.

I'm sorry I don't have more desirable feedback for your patch, but
it's the best I can do :-)

Reply to: