Hi Justin, On [06/04/04 18:06], Justin A wrote: > On Tue, Apr 06, 2004 at 08:22:24PM +0200, Christian Kurz wrote: > > the package john, currently maintained by Javier Fern?ndez-Sanguino Pe?a > > and myself, is failing to build on sparc. This was reported as bug > > #220928. Paul Slootman then suggested that the benchmark programs fails [...] > alrighty :-) The problem seems to be in des itself, I haven't figurd > out where yet, but I did find this: > diff -r -u john-1.6.orig/src/MD5_std.c john-1.6/src/MD5_std.c > --- john-1.6.orig/src/MD5_std.c 2000-04-01 05:21:43.000000000 -0500 > +++ john-1.6/src/MD5_std.c 2004-04-06 18:01:19.000000000 -0400 > @@ -416,7 +416,7 @@ > { > int length; > - for (length = 0; salt[length] && length < 8; length++); > + for (length = 0; length < 8 && salt[length] ; length++); > memcpy(patterns.s, salt, patterns.l.s = length); > } Thank you very much for debugging the problem and providing a patch to fix it. Which .orig are you exactly talking about here? I just extracted the .orig.tar.gz on my hd and it only contains line marked with a '-'. The md5sum for my .orig.tar.gz is: 9cf20a5bd0999f9683cf47c5bd8aaed3 john_1.6.orig.tar.g Christian -- Debian Developer (http://www.debian.org) 1024D/B7CEC7E8 44BD 1F9E A997 3BE2 A44F 96A4 1C98 EEF3 B7CE C7E8
Attachment:
pgpVPlM3phBXT.pgp
Description: PGP signature