[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [snapshot/master] Use SHA1.file().hexdigest, because ruby calculates the SHA1 wrong on large input otherwise (#668294)



Hi Peter,

Please consider accepting the attached patch for that check

And now that I have got a list of mismatched sums -- what would be the
reasonable course of action?  here they are FWIW

1caa9a6a88c34626afbeb4bbb5db8832b1417d49: Hash mismatch (d1f4a593b1196e66b1b53d769d5e73fa115498c0)
1c3d3c7d1dfec8a5d1d6bf953f6b8eb09788cad4: Hash mismatch (c73e3b7247b14bcf9432f539f9f651597a728b29)
30cd285f222bd8fadcf3742205cebd085809de1c: Hash mismatch (0f0a4469e5efa0d107f2a3e750d6fef8b51ff282)
38a77ce4bf31ffd69e5e7073a4f0740cedbfd7d6: Hash mismatch (82f1ead3d54c2cf6c6add5127ee11e90cbc02955)
3c0d79752cce99995f3a1e6923107f9cf80b33d4: Hash mismatch (7aadc2d7cac00304b282ce105360b65f65f0bcc4)
483eea0bd65f9a1ecb4d4fa27e158848c937f9f8: Hash mismatch (1c50e0494a53714a8d415a0e53d0e1b9aa9f1360)
6d2065bc0263ed2c0b1a8384fa7a35033ad2f294: Hash mismatch (c497409bdacaa07930d596a175cfb26cbb051e53)
76faaa2584edeefb2579d7d45cd57a7c22eecd47: Hash mismatch (dc592a06e8eece238cb0938774b769525a4bbde3)
986f3cf33f8de3267532c04c696592ba1209c003: Hash mismatch (0d6e6610ad52063560b777d08c1a1800145e40b0)
9bc3b26606e2fa33a44704d9dc5d208b3c2dcfa9: Hash mismatch (11038d3f281efb21b4d21d4e63d4de259897cd78)
9fb2c2d3940139a42d09f66844013e3c30b36089: Hash mismatch (e9cf05c6ee09d49e5ef8496433785d7de4dd0d57)
a12ea622a1ef676bf93ce0498f54583e825bc368: Hash mismatch (5e7105a8d989f2eea462a385b4bc56a90d8d4485)
a9258240b860351f8af29cdf0648fc8523fa27c6: Hash mismatch (96d4b1f29c9672fa130bd109d2c0c59d561e925d)
b0742bd352bec323c2b8d6b2168bdf01a6ab2352: Hash mismatch (b148d4ba7f1e07a59df3538b30a05a8df41788b9)
ca3325cf34f362af3c17350497300ec05da8659f: Hash mismatch (e4d9adad7c115b5e0e6fbe4962953a73b6540302)
d12afdbcbe213d07ce921d9a96be8f18f6407172: Hash mismatch (c8524c42e8200b6745dcf027bbfbbaf1cc07e3a8)
cf7640a2dade0db3edea3350779be8bd0cc6f571: Hash mismatch (2ad2419e034ff1c208aa5ef6201f19648116f419)
df9ca2daa7a2d6e9722cf1b7ec56936996aad01d: Hash mismatch (5a712cb7e2b1be37a0d5606426e24c69197077c0)
eb9b738c1821a3cfa3ac7589b79eb3e7f1d34b1d: Hash mismatch (2693b9be2ca06bf8ac9cafb0cc42b0b78596cd13)
f051f318f46e8adb66c067ad48e0b2899c0509f5: Hash mismatch (5d4b4d340be14ed062a5e96bc43af33d2fd9ec40)


On Wed, 11 Apr 2012, Peter Palfrader wrote:

> On Tue, 10 Apr 2012, Yaroslav Halchenko wrote:

> > Hi Peter,

> > does it mean that anything needs to be done on already existing entries?
> > and does "large" has any concrete number here? ;)

> Run fsck/check-1.  It will tell you about problems.
-- 
=------------------------------------------------------------------=
Keep in touch                                     www.onerussian.com
Yaroslav Halchenko                 www.ohloh.net/accounts/yarikoptic
From bd9be095f798d05753b4863c1e12adc415bb26ff Mon Sep 17 00:00:00 2001
From: Yaroslav Halchenko <debian@onerussian.com>
Date: Wed, 11 Apr 2012 12:56:41 -0400
Subject: [PATCH] allow some directories being absent from the farm in check-1

can happen on smaller archives where space of sums is much smaller than of Debian proper
---
 fsck/check-1/hash |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fsck/check-1/hash b/fsck/check-1/hash
index 32bb5d2..e5ee0b5 100755
--- a/fsck/check-1/hash
+++ b/fsck/check-1/hash
@@ -70,6 +70,9 @@ try:
         for byte2 in xrange(256):
             if verbose >= 2: print "queueing %02x%02x:"%(byte1, byte2)
             p = os.path.join(farmpath, '%02x'%byte1, '%02x'%byte2)
+            if not os.path.exists(p):
+                # not-that-large archives as Debian might be missing some
+                continue 
             for filename in os.listdir(p):
                 if re.match('[0-9a-f]{40}$', filename) is None:
                     errors.append((filename, 'Invalid name'))
-- 
1.7.9.1

Attachment: signature.asc
Description: Digital signature


Reply to: