Hi Sven, Thanks for the review! On Wed, Sep 03, 2025 at 06:01:03PM +0200, Sven Geuer wrote: [...] > debian/acct.default > ============== > > Not backward compatible changes, i.e. removal of support for > ACCT_ENABLE, should get pointed out in an entry to debian/NEWS. I wondered if the comments in the config diff presented on upgrade would be enough and whether the notability bar for NEWS was reached - I have my answer now! Done. [...] > debian/patches/*.patch > ====================== > > Harmonize headers to follow modern DEP-3, i.e. > - 'Description' instead of 'Subject' > - 'Author' instead of 'From' > - 'Last-Update' instead of 'Date' > - Add 'Last-Update' where missing > > Consider forwarding patches to upstream and document the fact by > populating Forwarded fields (does not inhibit upload to the Debian > repository). > > debian/extra/dump-acct.8 and dump-utmp.8 > ======================================== > > Consider providing these manpages to upstream (does not inhibit upload > to the Debian repository). If you don't mind, I have reserved upstreaming of patches and man pages to a later revision: there are outstanding bugs on both in the BTS for me to look at and unmerged upstream patches to review that may influence the outcome and I think this is a big enough update already! I didn't actually add maintainer manpages, by the way, I just made it explicit that that was what they were instead of continuing to carry a 'replace-all' patch. This is more transparent and should make changes easier! I do need to review them to see what changed from the upstream ones and why, etc., in a future iteration. > That's all! Let me know, when you think acct is ready for upload. I can't think of anything else for this round. Thanks! Andrew
Attachment:
signature.asc
Description: PGP signature