Hi Andrew,
On Fri, 2025-08-29 at 16:22 +0200, Sven Geuer wrote:
> Thanks for your work. I hope to come back to you with my review results
> in a few days.
Thank you again for your carefully done work.
There are only a few changes and/or additions it like to ask you to
handle:
debian/README.Debian
===============
[...] See #922533 [...]
As a convenience for the reader, I suggest to write 'See bug #922533'
and to provide a link, like https://bugs.debian.org/922533.
debian/acct.default
==============
Not backward compatible changes, i.e. removal of support for
ACCT_ENABLE, should get pointed out in an entry to debian/NEWS.
debian/copyright
===========
Indent 'Files: *' and 'Files: debian/*' for readability, e.g.
Copyright: 1993-1998 Noel Cragg <noel@gnu.ai.mit.edu>
2003 Ciaran O'Riordan <ciaran@member.fsf.org>
2005-2006 Tim Schmielau <tim@physik3.uni-rostock.de>
2009-2014 Markus Gothe <nietzsche@lysator.liu.se>
Sort 'Files: debian/*' by increasing years, i.e.
Copyright: ?-1995 Ian Murdock
1995-2003 Dirk Eddelbuettel <edd@debian.org>
...
2025 Andrew Bower <andrew@bower.uk>
debian/patches/*.patch
======================
Harmonize headers to follow modern DEP-3, i.e.
- 'Description' instead of 'Subject'
- 'Author' instead of 'From'
- 'Last-Update' instead of 'Date'
- Add 'Last-Update' where missing
Consider forwarding patches to upstream and document the fact by
populating Forwarded fields (does not inhibit upload to the Debian
repository).
debian/extra/dump-acct.8 and dump-utmp.8
========================================
Consider providing these manpages to upstream (does not inhibit upload
to the Debian repository).
debian/rules
============
line 'export DEB_CFLAGS_MAINT_APPEND = -D_TIME_BITS_64' is unneeded,
'export DEB_BUILD_MAINT_OPTIONS = ... abi=+time64' already adds it. It
does it even more correctly by adding the definition to CPPFLAGS, see
https://manpages.debian.org/unstable/dpkg-dev/dpkg-buildflags.1.en.html#time64
for details. As it is now the definition gets added twice, see
https://salsa.debian.org/pkg-security-team/acct/-/jobs/8144018#L2140.
Lines
override_dh_auto_clean:
dh_auto_clean
[...]
should get shortened to
execute_after_dh_auto_clean:
[...]
Likewise
override_dh_auto_build:
dh_auto_build
debian/changelog
================
Keep the distribution field of the latest changelog reset to
'UNRELEASED' up until the sources are about to get uploaded, i.e. a
real 'Update changlog for release ...' commit is going to be made. With
needing an uploading sponsor it is up to the sponsor to populate the
field with the intended distribution.
Finally
=======
Run 'wrap-and-sort -at' for a consistent format of various Debian
packaging files.
That's all! Let me know, when you think acct is ready for upload.
Best,
Sven
--
GPG Fingerprint
3DF5 E8AA 43FC 9FDF D086 F195 ADF5 0EDA F8AD D585
Attachment:
signature.asc
Description: This is a digitally signed message part