Hello Raphael, On 1/8/21 9:23 AM, Raphael Hertzog wrote:
Hi, On Thu, 24 Dec 2020, Francisco Vilmar Cardoso Ruviaro wrote:I fixed an RC bug [0] in librtr [1]. Please, review and upload.Adrian Bunk pointed out that your fix is clearly incorrect. Can you at least revert your change please ?It would be nice if you tried to
Sure, it's done.
understand your changes before you are doing them. A symbol that disappears is a big deal because it breaks users of the library that are using this symbol. So it was relatively evident that the correct fix was not to acknowledge the disparition of the symbol (at least not without an explanation of why it's not important).
Thanks Raphael, I need to be more careful and pay attention before any change, you're right, I need to understand better.
He also pointed towards a possible upstream fix. Do you want to look into backporting this?
I tried to get the latest version (0.7.0+git20201012.93724e4), applied the patch https://github.com/rtrlib/rtrlib/pull/260/commits/f81b70bf03a52b2e25f7154062c538dc050b3571 yet the bug continues. Unfortunately I was not successful. Regards, -- Francisco Vilmar Cardoso Ruviaro <francisco.ruviaro@riseup.net> 4096R: 1B8C F656 EF3B 8447 2F48 F0E7 82FB F706 0B2F 7D00
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature