[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request to review and upload librtr 0.6.3-2



Hi,

On Thu, 24 Dec 2020, Francisco Vilmar Cardoso Ruviaro wrote:
> I fixed an RC bug [0] in librtr [1].
> 
> Please, review and upload.

Adrian Bunk pointed out that your fix is clearly incorrect. Can you at
least revert your change please ? It would be nice if you tried to
understand your changes before you are doing them. A symbol that
disappears is a big deal because it breaks users of the library
that are using this symbol. So it was relatively evident that the
correct fix was not to acknowledge the disparition of the symbol
(at least not without an explanation of why it's not important).

He also pointed towards a possible upstream fix. Do you want to look into
backporting this?

Cheers,
-- 
  ⢀⣴⠾⠻⢶⣦⠀   Raphaël Hertzog <hertzog@debian.org>
  ⣾⠁⢠⠒⠀⣿⡁
  ⢿⡄⠘⠷⠚⠋    The Debian Handbook: https://debian-handbook.info/get/
  ⠈⠳⣄⠀⠀⠀⠀   Debian Long Term Support: https://deb.li/LTS

Attachment: signature.asc
Description: PGP signature


Reply to: